Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcm53xx: build a single device per profile #13577

Closed
wants to merge 1 commit into from
Closed

bcm53xx: build a single device per profile #13577

wants to merge 1 commit into from

Conversation

raenye
Copy link
Contributor

@raenye raenye commented Sep 30, 2023

So far every build of a single bcm53xx device resulted in 18 TRX being built. Now it only builds the selected one.

Fixes: #13572

Thank you @KanjiMonster for the solution and the discussion.

@raenye
brcm53xx: build a single device per profile
2155b39 
So far every build of a single bcm53xx device resulted in
18 TRX being built. Now it only builds the selected one.

Fixes: openwrt#13572

Suggested-by: Jonas Gorski <jonas.gorski@gmail.com>
Signed-off-by: Rani Hod <rani.hod@gmail.com>
@github-actions github-actions bot added the target/bcm53xx pull request/issue for bcm53xx target label Sep 30, 2023
@Ansuel
Copy link
Member

Ansuel commented Oct 2, 2023

@raenye guess this should be also backported?

@raenye
Copy link
Contributor Author

raenye commented Oct 2, 2023

I guess, it makes sense.

@rmilecki
Copy link
Contributor

I tried building OpenWrt with following base config:

CONFIG_TARGET_bcm53xx=y
CONFIG_TARGET_bcm53xx_generic=y
CONFIG_TARGET_MULTI_PROFILE=y
CONFIG_TARGET_DEVICE_bcm53xx_generic_DEVICE_asus_rt-ac3100=y
CONFIG_TARGET_DEVICE_PACKAGES_bcm53xx_generic_DEVICE_asus_rt-ac3100=""
CONFIG_TARGET_PER_DEVICE_ROOTFS=y

Without and with this patch in bin/targets/bcm53xx/generic/ there is only one device image: openwrt-bcm53xx-generic-asus_rt-ac3100-squashfs.trx. I also don't see any difference in build_dir/target-arm_cortex-a9_musl_eabi/linux-bcm53xx_generic/ with or without this change.

Could you give me some extra hint how to test this, please?

@raenye raenye changed the title brcm53xx: build a single device per profile bcm53xx: build a single device per profile Oct 12, 2023
@raenye
Copy link
Contributor Author

raenye commented Oct 12, 2023

Could you give me some extra hint how to test this, please?

Could you please try using the Linksys EA9200 profile? thank you.

@rmilecki
Copy link
Contributor

Could you please try using the Linksys EA9200 profile? thank you.

Same result.

@rmilecki
Copy link
Contributor

802a5f5 ("bcm53xx: build a single device per profile main master")

I'll cherry-pick it to openwrt-23.05 after weekend just to make sure it doesn't break anything.

@rmilecki rmilecki closed this Oct 13, 2023
@raenye raenye deleted the bcm53xx-single-device-build branch November 12, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linusw linusw linusw approved these changes

Assignees
No one assigned
Labels
target/bcm53xx pull request/issue for bcm53xx target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bcm53xx: build fails with default config
4 participants
@raenye @Ansuel @rmilecki @linusw