-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] bcm63xx: drop target #14559
[RFC] bcm63xx: drop target #14559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's focus the community efforts on improving bmips instead.
Sounds like a good plan, thus this proposal makes sense to me, thanks!
BTW feel free to move it over to https://github.com/openwrt/targets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, especially since there is a target that replaces it
I'm adding support for a BCM63168 OEM router and i found that the "gpio-leds" does not work BMIPS target. It worked on the old BCM63xx target. I removed the "gpio-leds" in the DTS and compiled it against the latest BMIPS codes, then tried to control the LEDs via In my DTS, LEDs driven by the 74HC161 shift-register and GPIO LEDs (<24) are controlled by the hardware LED controller and working as expected. However, my router has LEDs that are attached to GPIOs >32, and "gpio-leds" is the only option, as the LED controller hardware only supports up to 24 LEDs. In my BMIPS image, command This wiki page said that:
So I think there might be some problem with the GPIO controller driver on the BMIPS target? |
@rikka0w0 as @ynezz already stated, please open a new PR as draft and I/others will try to help you there. |
BCM63xx maintainance is a PITA since there's no full Device Tree support and therefore every board needs it's own definition in board_bcm963xx.c There's no DSA support for this board and there have been very few contributions in the last years. Moreover, BCM63xx SoCs >= BCM6358 are already supported in bmips target, so any efforts to keep this target alive aren't worth the time. Let's focus the community efforts on improving bmips instead. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Done, openwrt/targets@a1497c4 |
bcm63xx maintainance is a PITA since there's no full Device Tree support and therefore every board needs it's own definition in board_bcm963xx.c.
There's no DSA support for this target and there have been very few contributions in the last years.
Moreover, BCM63xx SoCs >= BCM6358 are already supported in bmips target, so any efforts to keep this target alive aren't worth the time.
Let's focus the community efforts on improving bmips instead.
CC @ffainelli @KanjiMonster @danitool