Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] bcm63xx: drop target #14559

Merged
merged 1 commit into from
Mar 4, 2024
Merged

[RFC] bcm63xx: drop target #14559

merged 1 commit into from
Mar 4, 2024

Conversation

Noltari
Copy link
Member

@Noltari Noltari commented Feb 5, 2024

bcm63xx maintainance is a PITA since there's no full Device Tree support and therefore every board needs it's own definition in board_bcm963xx.c.
There's no DSA support for this target and there have been very few contributions in the last years.
Moreover, BCM63xx SoCs >= BCM6358 are already supported in bmips target, so any efforts to keep this target alive aren't worth the time.
Let's focus the community efforts on improving bmips instead.

CC @ffainelli @KanjiMonster @danitool

@Noltari Noltari added the RFC pull request ready for comments label Feb 5, 2024
@Noltari Noltari mentioned this pull request Feb 5, 2024
42 tasks
@github-actions github-actions bot added target/bcm63xx pull request/issue for bcm63xx target kernel pull request/issue with Linux kernel related changes labels Feb 5, 2024
@Noltari Noltari changed the title bcm63xx: drop target [RFC] bcm63xx: drop target Feb 5, 2024
Copy link
Member

@ynezz ynezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's focus the community efforts on improving bmips instead.

Sounds like a good plan, thus this proposal makes sense to me, thanks!

@ynezz
Copy link
Member

ynezz commented Mar 1, 2024

BTW feel free to move it over to https://github.com/openwrt/targets

@robimarko robimarko self-requested a review March 1, 2024 18:26
Copy link
Contributor

@robimarko robimarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, especially since there is a target that replaces it

@rikka0w0
Copy link

rikka0w0 commented Mar 2, 2024

Let's focus the community efforts on improving bmips instead.

I'm adding support for a BCM63168 OEM router and i found that the "gpio-leds" does not work BMIPS target. It worked on the old BCM63xx target. I removed the "gpio-leds" in the DTS and compiled it against the latest BMIPS codes, then tried to control the LEDs via /sys/class/gpio, it doesn't work, except for GPIO8. (I tried to toggle all 52 GPIOs)

In my DTS, LEDs driven by the 74HC161 shift-register and GPIO LEDs (<24) are controlled by the hardware LED controller and working as expected. However, my router has LEDs that are attached to GPIOs >32, and "gpio-leds" is the only option, as the LED controller hardware only supports up to 24 LEDs.

In my BMIPS image, command ls /sys/class/gpio gives: export gpiochip460 unexport and cat /sys/class/gpio/gpiochip460/ngpio gives 52. But I remembered back in the BCM63xx target, there were two gpiochip instances.

This wiki page said that:

When having more than 32 GPIOs they are splitted between 2 gpiochips. The labels in the Linux kernel are:

bcm63xx-gpio.0
bcm63xx-gpio.1

So I think there might be some problem with the GPIO controller driver on the BMIPS target?

#14664

@Noltari
Copy link
Member Author

Noltari commented Mar 4, 2024

Let's focus the community efforts on improving bmips instead.

I'm adding support for a BCM63168 OEM router and i found that the "gpio-leds" does not work BMIPS target. It worked on the old BCM63xx target. I removed the "gpio-leds" in the DTS and compiled it against the latest BMIPS codes, then tried to control the LEDs via /sys/class/gpio, it doesn't work, except for GPIO8. (I tried to toggle all 52 GPIOs)

In my DTS, LEDs driven by the 74HC161 shift-register and GPIO LEDs (<24) are controlled by the hardware LED controller and working as expected. However, my router has LEDs that are attached to GPIOs >32, and "gpio-leds" is the only option, as the LED controller hardware only supports up to 24 LEDs.

In my BMIPS image, command ls /sys/class/gpio gives: export gpiochip460 unexport and cat /sys/class/gpio/gpiochip460/ngpio gives 52. But I remembered back in the BCM63xx target, there were two gpiochip instances.

This wiki page said that:

When having more than 32 GPIOs they are splitted between 2 gpiochips. The labels in the Linux kernel are:

bcm63xx-gpio.0
bcm63xx-gpio.1

So I think there might be some problem with the GPIO controller driver on the BMIPS target?

#14664

@rikka0w0 as @ynezz already stated, please open a new PR as draft and I/others will try to help you there.
Posting this here is offtopic.

BCM63xx maintainance is a PITA since there's no full Device Tree support and
therefore every board needs it's own definition in board_bcm963xx.c
There's no DSA support for this board and there have been very few
contributions in the last years.
Moreover, BCM63xx SoCs >= BCM6358 are already supported in bmips target, so
any efforts to keep this target alive aren't worth the time.
Let's focus the community efforts on improving bmips instead.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@openwrt-bot openwrt-bot merged commit 5cd8e03 into openwrt:main Mar 4, 2024
27 checks passed
@Noltari Noltari deleted the bcm63xx-drop branch March 4, 2024 15:14
@Noltari
Copy link
Member Author

Noltari commented Mar 4, 2024

BTW feel free to move it over to https://github.com/openwrt/targets

Done, openwrt/targets@a1497c4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel pull request/issue with Linux kernel related changes RFC pull request ready for comments target/bcm63xx pull request/issue for bcm63xx target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants