New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipq40xx: use NVMEM-on-UBI for ASUS devices #14729
base: main
Are you sure you want to change the base?
Conversation
@remittor Would be glad if you can take a look |
69e7a9a
to
7268dc0
Compare
I think I'll try to take my MR33 on a spin for it - it stores caldata on both raw MTD and UBI, the latter being currently preferred by OpenWrt implementation. |
7268dc0
to
778559a
Compare
Instead of extracting WiFi precal as well as MAC addresses in userspace use recently introduced NVMEM-on-UBI instead. Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Instead of extracting WiFi precal as well as MAC addresses in userspace use recently introduced NVMEM-on-UBI instead. Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Instead of extracting WiFi precal as well as MAC addresses in userspace use recently introduced NVMEM-on-UBI instead. Signed-off-by: Daniel Golle <daniel@makrotopia.org>
778559a
to
979c57b
Compare
Since I don't have any of these boards, I can just say that the changes look sane to me. |
@robimarko Thank you for reviewing. The thing is that ASUS bootloaders are full of surprises and may do things like replacing the MTD partitions in DT... So it will need to be tested by someone who got the device. |
Yes, which is why I am refraining from merging this until somebody runtime test this. |
I've tested this with an ASUS RT-AC58U. from what I can tell, it works.
Content of EDIT:
|
Some recent ASUS devices started storing their factory data inside a UBI volume. Instead of extracting WiFi EEPROM data and MAC addresses in userspace, use the now available new way to reference the NVMEM bits in device tree.
Lacking the hardware no runtime testing has been done on my end, hence I rely on users to give feedback if this series works as intended.
User tested and confirmed MAC addresses and WiFi EEPROM:
Similar changes for mediatek/filogic-based ASUS devices:
#14676