Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ar71xx: Fix FS#1805 (build failure for tiny targets due to -Wpacked-not-aligned introduced by GCC 8) #1484

Closed
wants to merge 1 commit into from

Conversation

hardfalcon
Copy link
Contributor

Fix build failure for ar71xx tiny targets by correcting alignment for struct ipv6_destopt_hao in include/uapi/linux/ipv6.h

Fix build failure for ar71xx tiny targets by correcting alignment for struct ipv6_destopt_hao in include/uapi/linux/ipv6.h
@dedeckeh dedeckeh added the target/ar71xx pull request/issue for ar71xx target label Oct 21, 2018
@xback
Copy link
Contributor

xback commented Oct 29, 2018

I've compile-tested following targets as suggested in the FS ticket [1]

  • tl-wa860re-v1
  • tl-wr710n-v2

Both build fine.

Which compiler version are you using?

[1] https://bugs.openwrt.org/index.php?do=details&task_id=1805

@hardfalcon
Copy link
Contributor Author

hardfalcon commented Nov 5, 2018

Like I wrote in the bug report, the build failure that this PR fixes occurs with gcc 8.2.

Using the default, which is gcc 7.3, the error doesn't occur.

For the sake of completeness: The error described in the bug report is probably triggered by -Wpacked-not-aligned which was introduced with GCC 8 and is part of -Wall.

@hardfalcon hardfalcon changed the title ar71xx: Fix FS#1805 (build failure for tiny targets) ar71xx: Fix FS#1805 (build failure for tiny targets due to -Wpacked-not-aligned introduced by GCC 8) Nov 6, 2018
Copy link

@adde88 adde88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also fixes the exact same issue when tryingto compile latest master with the target being a WiFi Pineapple TETRA (custom code, trying to merge with master branch).

I got the exact same error message, and this fixes it.

@jow-
Copy link
Contributor

jow- commented Jan 30, 2019

Pulled into my staging tree at https://git.openwrt.org/openwrt/staging/jow.git

@jow- jow- closed this Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target/ar71xx pull request/issue for ar71xx target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants