kernel: modules: video: drm: fixup 6.6 adaptations #14899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kernel
|
@hauke Any chance you could sanity check this? |
|
Looking at Since amdgpu seems to be the only one of these being packaged by us currently, these should be moved into drm-amdgpu instead to avoid breaking amdgpu for 6.6. |
|
Yeah, let me switch to x86 as amdgpu is limited to it only(Hence why it did not fail on mediatek) and try packaging these separately. And done, now they are selected when required and x86 compiles fine. |
robimarko
force-pushed
the
mediatek-6.6-ci
branch
from
9d29ae8
to
4e88b7e
Compare
robimarko
changed the title
As part of adding kernel 6.6 support, DRM_EXEC and DRM_SUBALLOC_HELPER were added to the kmod-drm, however these are only used by drm-amdgpu and drm-radeon which are only supported on x86. So, lets start fixing building of other targets by removing these from the main kmod-drm, in follow-up commits they will be packaged separately and selected when required. Fixes: 5b08b56 ("kernel: modules: video: adapt for kernel 6.6") Signed-off-by: Robert Marko <robimarko@gmail.com>
Linux 6.6 has added DRM EXEC as a separate symbol, so package it separately as AMDGPU requires it. Signed-off-by: Robert Marko <robimarko@gmail.com>
Linux 6.4 has split out the previously AMDGPU specific suballocation helper into a generic one and it has its own symbol now. So, lets package it as a separate helper as AMDGPU still requires it for 6.6. Signed-off-by: Robert Marko <robimarko@gmail.com>
…MDGPU drm-amdgpu and drm-radeon require drm-exec and/or drm-suballoc-helper in 6.6, so since we have them packaged separately include them when required. Fixes: 5b08b56 ("kernel: modules: video: adapt for kernel 6.6") Signed-off-by: Robert Marko <robimarko@gmail.com>
robimarko
force-pushed
the
mediatek-6.6-ci
branch
from
4e88b7e
to
8fb2346
Compare
|
Thanks! Rebased on top of main and merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of adding kernel 6.6 support, DRM_EXEC and DRM_SUBALLOC_HELPER were added to the kmod-drm, however these are not used by any kmod we package and currently cause a build failure for mediatek targets.
So, remove both of these for now from the main DRM kmod, package them individually and select for AMDGPU and radeon kmods.
Fixes: 5b08b56 ("kernel: modules: video: adapt for kernel 6.6")