-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ramips: Add support for Creality WB-01 #15021
base: main
Are you sure you want to change the base?
Conversation
Duplicate of #3802 |
hi @shivajiva101 |
Hi @Npeca75 chepo92 made it clear that it was the work of figgc he was effectively bumping by including him as the author in the pr commit message, you should probably do the same just so there's no confusion as to the source. See #13150 (comment) for how to add yourself properly to the chain. |
It's whatever you're comfortable with at the end of the day. Personally I'd like to see the hardware officially supported, it will make my life easier 🤷♂️ |
well, i restored my original branch after all |
that's convenient for you, along with the claim it was clean room coded despite using the same older code style as figgyc and needing to be asked to update the leds format. I'm surprised the devs aren't being more vocal on how this appears but hey ho let's hope you can get it merged for everyone's convenience |
ok, since your opinion is that every similarity in LED naming, or in ? in what? install procedure? is pure robbery ? steal ? should i close this PR for your satisfy ? |
@Npeca75 great job and nice to have a more detailed commit can we colaborate so we get any pr merged? Besides, Shivajiva and other guys have been doing some further work in the discord, you should join if interested |
hi @chepo92 , yes, i am open to anything which will bring this device to official support ... but please, could we message each other on OWRT forum about collaboration? i am not so good with GIT and since it is my first PR , mostly confused with workflow ... |
Don't be silly I want the PR merged. Just pointing out someone already bought the hardware, peeled it open and did the reverse engineering to make the first PR for this, regardless of you claiming ignorance to that event. Seems logical that they would be credited in any subsequent PR out of respect for their efforts, once you were aware, and that's literally all I'm pointing out to you. A major portion of the code for your PR was already in existence in the first PR due to the nature of the structure created specifically for adding hardware. |
same as i did. it is here, attached on 2pcs of USB printer since p910nd was broken for 2 usb port operation, i sent a PR to packages which is accepted, since then p910nd is OK anyway, if you wish to help me, please help me trough GIT how to done it properly |
Sure, as the owner of the pr you can edit your commit comments, make further changes etc up to the merge point where it will probably be squashed into a single commit. You don't have to force push anything just keep working on the branch the pr originates from. Make the changes requested by the dev handling this and keep on it so it doesn't sit forever. |
What's your problem with git? Usually, I use the GUI (gitk) for most operations (rebasing is an exception). I create a single commit with my changes. If the review requires changes (that is very, very common), then I make the changes and select "Commit" -> "Amend last commit" to just get it into the same commit. Force-Push and you're done. No need to squash or merge anything. That said, for rebasing, I follow two guides in this order:
@shivajiva101 With my first few PRs, I was always told to squash everything into a single commit. I wasn't very proficient with git at that time, so I established the above-mentioned workflow. |
@andyboeh fair enough, the pr history isn't relevant to the project history tree and the requested changes are visible in the pr regardless, so it's a valid approach and definitely looks cleaner |
I think the issue with the Test Formalities check failing is trying to author figgyc in when you are the author of the pr, github doesn't allow it to prevent forged commits iirc |
i was confused where and how should i mention figgyc in commit, and since @shivajiva101 was demanding to include figgyc, i was hopping that he will give me some real and usable instruction how to do this |
@Npeca75 your last push looks okay to me 👍 |
CREALITY BOX WB01 is small footprint router based on MediaTek MT7688 Specifications: - SoC: MediaTek MT7688 580MHz - RAM: DDR2 128M - Flash: BY25Q128AS (16 MiB, SPI NOR) handled by BoHong bh25q128as driver - WiFi: 2.4GHz 1T1R internal panel antenna - Ethernet: 1x LAN (10/100) - USB: 2x USB2.0 port - UART: 3.3V, TX, RX, GND / 56700 8N1 / only pads on PCB - micro USB input (for power only) - reset button - FCC ID: 2AXH6CREALITY-BOX MAC addresses as verified by OEM firmware: vendor OpenWrt source LAN eth0 factory 0x2e 2.4GHz phy0-ap0 factory 0x04 (label) LEDs color vendor OpenWRT configurable red SD card activity - yes green Cloud connectivity status yes blue LAN activity eth0 yes yellow WIFI activity phy0tpt yes Return to OEM & debrick - download "cxsw_update.tar.bz2" from manufacturer site - extract archive to FAT32 USB stick root - put USB stick in USB2 port - press & hold reset button - power on device while holding reset - wait approx 10 sec - release reset button Installation with SD Card - power on device - wait for device to finish starting - copy "openwrt-ramips-mt76x8-creality_wb-01-squashfs-cxsw_update.tar.bz2" to root of FAT32 SD card - rename openwrt-ramips-mt76x8-creality_wb-01-squashfs-cxsw_update.tar.bz2 to "cxsw_update.tar.bz2" - put SD card in device - device will install OpenWRT on internal flash Installation via telnet: - extract the "factory.bin" and "install.sh" from newly created openwrt-ramips-mt76x8-creality_wb-01-squashfs-cxsw_update.tar.bz2 to FAT32 USB stick root - telnet to 10.10.10.254, user: root, password: cxswprin - plug the USB in USB1 port - cd /media/usbdisk/ - sh install.sh - device will write "factory.bin" to internal flash Co-authored-by: George Brooke <figgyc@figgyc.uk> Signed-off-by: Peca Nesovanovic <peca.nesovanovic@sattrakt.com>
would you please review and approve this PR ? @rmilecki |
@Npeca75 I don't have write access so I can't be of any help to you in that respect. Can the blue led be configured as link on, transmit & receive to reflect the status on that interface as the default behaviour? |
CREALITY BOX WB01 is small footprint router based on MediaTek MT7688
Specifications:
MAC addresses as verified by OEM firmware:
LEDs
Return to OEM & debrick
Installation with SD Card
Installation via telnet: