Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ramips: Add support for Creality WB-01 #15021

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Npeca75
Copy link

@Npeca75 Npeca75 commented Mar 30, 2024

CREALITY BOX WB01 is small footprint router based on MediaTek MT7688

Specifications:

  • SoC: MediaTek MT7688 580MHz
  • RAM: DDR2 128M
  • Flash: BY25Q128AS (16 MiB, SPI NOR) handled by BoHong bh25q128as driver
  • WiFi: 2.4GHz 1T1R internal panel antenna
  • Ethernet: 1x LAN (10/100)
  • USB: 2x USB2.0 port
  • UART: 3.3V, TX, RX, GND / 56700 8N1 / only pads on PCB
  • micro USB input (for power only)
  • reset button
  • FCC ID: 2AXH6CREALITY-BOX

MAC addresses as verified by OEM firmware:

vendor   OpenWrt    source
LAN      eth0       factory 0x2e
2.4GHz   phy0-ap0   factory 0x04 (label)

LEDs

color    vendor                OpenWRT     configurable
red      SD card activity        -             yes
green    Claoud connectivity   status          yes
blue     LAN activity          eth0            yes
yellow   WIFI activity         phy0tpt         yes

Return to OEM & debrick

  • download "cxsw_update.tar.bz2" from manufacturer site
  • extract archive to FAT32 USB stick root
  • put USB stick in USB2 port
  • press & hold reset button
  • power on device while holding reset
  • wait approx 10 sec
  • release reset button

Installation with SD Card

  • power on device
  • wait for device to finish starting
  • copy "openwrt-ramips-mt76x8-creality_wb-01-squashfs-cxsw_update.tar.bz2" to root of FAT32 SD card
  • rename openwrt-ramips-mt76x8-creality_wb-01-squashfs-cxsw_update.tar.bz2 to "cxsw_update.tar.bz2"
  • put SD card in device
  • divice will install OpenWRT on internal flash

Installation via telnet:

  • extract the "factory.bin" and "install.sh" from newly created openwrt-ramips-mt76x8-creality_wb-01-squashfs-cxsw_update.tar.bz2 to FAT32 USB stick root
  • telnet to 10.10.10.254, user: root, password: cxswprin
  • plug the USB in USB1 port
  • cd /media/usbdisk/
  • sh install.sh
  • device will write "factory.bin" to internal flash

@github-actions github-actions bot added the target/ramips pull request/issue for ramips target label Mar 30, 2024
@shivajiva101
Copy link

shivajiva101 commented Apr 3, 2024

Duplicate of #3802
You should at least credit the original author...

@Npeca75
Copy link
Author

Npeca75 commented Apr 3, 2024

Duplicate of #3802 You should at least credit the original author...

hi @shivajiva101
tnx for notification
there is 2 PR for this device, but both are unfinished and abandoned and somewhat wrong (MAC address, ETH switch)
#13150 and #3802
would you be so kind to guide me how and where to mention other two author?
this is my first PR so any help is welcome :)

@shivajiva101
Copy link

Hi @Npeca75 chepo92 made it clear that it was the work of figgc he was effectively bumping by including him as the author in the pr commit message, you should probably do the same just so there's no confusion as to the source. See #13150 (comment) for how to add yourself properly to the chain.

@github-actions github-actions bot added target/apm821xx pull request/issue for apm821xx target target/at91 pull request/issue for at91 target target/bcm53xx pull request/issue for bcm53xx target target/bcm47xx pull request/issue for bcm47xx target target/bcm63xx pull request/issue for bcm63xx target target/bcm27xx pull request/issue for bcm27xx target build/scripts/tools pull request/issues for build, scripts and tools related changes target/ipq806x pull request/issue for ipq806x target kernel pull request/issue with Linux kernel related changes target/kirkwood pull request/issue for kirkwood target target/lantiq pull request/issue for lantiq target target/layerscape pull request/issue for layerscape target target/mpc85xx pull request/issue for mpc85xx target target/mvebu pull request/issue for mvebu target core packages pull request/issue for core (in-tree) packages target/sunxi pull request/issue for sunxi target toolchain pull request/issue with toolchain related changes target/archs38 pull request/issue for archs38 target target/imx pull request/issue for imx (imx6) target target/ipq40xx pull request/issue for ipq40xx target target/ath79 pull request/issue for ath79 target target/mediatek pull request/issue for mediatek target target/imagebuilder pull request/issue for imagebuilder target labels Apr 3, 2024
@github-actions github-actions bot removed target/rockchip pull request/issue for rockchip target target/realtek pull request/issue for realtek target target/bcm4908 pull request/issue for bcm4908 target target/octeontx pull request/issue for octeontx target target/uml pull request/issue for uml target target/airoha pull request/issue for airoha target target/sifiveu pull request/issue for sifiveu target target/qualcommax pull request/issue for qualcommax target labels Apr 3, 2024
@shivajiva101
Copy link

It's whatever you're comfortable with at the end of the day. Personally I'd like to see the hardware officially supported, it will make my life easier 🤷‍♂️

@Npeca75
Copy link
Author

Npeca75 commented Apr 4, 2024

at the end of the day

well, i restored my original branch after all
CI/CD complaining about formalities with modified author, sorry, i have no more spare time for endless try

@shivajiva101
Copy link

that's convenient for you, along with the claim it was clean room coded despite using the same older code style as figgyc and needing to be asked to update the leds format. I'm surprised the devs aren't being more vocal on how this appears but hey ho let's hope you can get it merged for everyone's convenience

@Npeca75
Copy link
Author

Npeca75 commented Apr 4, 2024

that's convenient for you, along with the claim it was clean room coded despite using the same older code style as figgyc and needing to be asked to update the leds format. I'm surprised the devs aren't being more vocal on how this appears but hey ho let's hope you can get it merged for everyone's convenience

ok, since your opinion is that every similarity in LED naming, or in ? in what? install procedure? is pure robbery ? steal ? should i close this PR for your satisfy ?

@chepo92
Copy link

chepo92 commented Apr 4, 2024

@Npeca75 great job and nice to have a more detailed commit can we colaborate so we get any pr merged?
As you said 'CI/CD complaining about formalities with modified author, sorry, i have no more spare time for endless try'
Well, I did invest some time (I would said a lot) to pass CI/CD, was a PITA, but then got stuck with reviewer's comment and "didn't have more time"

Besides, Shivajiva and other guys have been doing some further work in the discord, you should join if interested

@Npeca75
Copy link
Author

Npeca75 commented Apr 4, 2024

can we colaborate

hi @chepo92 , yes, i am open to anything which will bring this device to official support ... but please, could we message each other on OWRT forum about collaboration? i am not so good with GIT and since it is my first PR , mostly confused with workflow ...

@shivajiva101
Copy link

that's convenient for you, along with the claim it was clean room coded despite using the same older code style as figgyc and needing to be asked to update the leds format. I'm surprised the devs aren't being more vocal on how this appears but hey ho let's hope you can get it merged for everyone's convenience

ok, since your opinion is that every similarity in LED naming, or in ? in what? install procedure? is pure robbery ? steal ? should i close this PR for your satisfy ?

Don't be silly I want the PR merged. Just pointing out someone already bought the hardware, peeled it open and did the reverse engineering to make the first PR for this, regardless of you claiming ignorance to that event. Seems logical that they would be credited in any subsequent PR out of respect for their efforts, once you were aware, and that's literally all I'm pointing out to you. A major portion of the code for your PR was already in existence in the first PR due to the nature of the structure created specifically for adding hardware.

@Npeca75
Copy link
Author

Npeca75 commented Apr 4, 2024

Just pointing out someone already bought the hardware, peeled it open

same as i did. it is here, attached on 2pcs of USB printer

since p910nd was broken for 2 usb port operation, i sent a PR to packages which is accepted, since then p910nd is OK
and, yes, this is why i sent PR for this device, without knowing for other two PRs
if you take a closer look, i am using switch, other two is using plain ETH0
image generating script is again, similar, but not same
in other two PR there is no option for flash with telnet ... so much about relying on other people job
my only sin is that i made same image name as in other PR since it is logical to be similar to "factory update file"

anyway, if you wish to help me, please help me trough GIT how to done it properly

@shivajiva101
Copy link

Sure, as the owner of the pr you can edit your commit comments, make further changes etc up to the merge point where it will probably be squashed into a single commit. You don't have to force push anything just keep working on the branch the pr originates from. Make the changes requested by the dev handling this and keep on it so it doesn't sit forever.

@andyboeh
Copy link
Contributor

andyboeh commented Apr 4, 2024

anyway, if you wish to help me, please help me trough GIT how to done it properly

What's your problem with git?

Usually, I use the GUI (gitk) for most operations (rebasing is an exception). I create a single commit with my changes. If the review requires changes (that is very, very common), then I make the changes and select "Commit" -> "Amend last commit" to just get it into the same commit. Force-Push and you're done. No need to squash or merge anything.

That said, for rebasing, I follow two guides in this order:

  1. Sync my fork according to the Github tutorial at https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork#syncing-a-fork-branch-from-the-command-line
  2. Rebase according to the Git book at https://git-scm.com/book/en/v2/Git-Branching-Rebasing

@shivajiva101 With my first few PRs, I was always told to squash everything into a single commit. I wasn't very proficient with git at that time, so I established the above-mentioned workflow.

@shivajiva101
Copy link

@andyboeh fair enough, the pr history isn't relevant to the project history tree and the requested changes are visible in the pr regardless, so it's a valid approach and definitely looks cleaner

@shivajiva101
Copy link

I think the issue with the Test Formalities check failing is trying to author figgyc in when you are the author of the pr, github doesn't allow it to prevent forged commits iirc

@Npeca75
Copy link
Author

Npeca75 commented Apr 5, 2024

What's your problem with git?

i was confused where and how should i mention figgyc in commit, and since @shivajiva101 was demanding to include figgyc, i was hopping that he will give me some real and usable instruction how to do this
... my first try with changing initial commit message was a mess, but hope now is OK

@shivajiva101
Copy link

shivajiva101 commented Apr 5, 2024

@Npeca75 your last push looks okay to me 👍
I'm hoping at this point you've realised it's nothing personal and literally if it was the other way round I'd be doing exactly the same for you!

@Npeca75 Npeca75 requested a review from rmilecki April 5, 2024 16:05
CREALITY BOX WB01 is small footprint router based on MediaTek MT7688

Specifications:
- SoC: MediaTek MT7688 580MHz
- RAM: DDR2 128M
- Flash: BY25Q128AS (16 MiB, SPI NOR) handled by BoHong bh25q128as driver
- WiFi: 2.4GHz 1T1R internal panel antenna
- Ethernet: 1x LAN (10/100)
- USB: 2x USB2.0 port
- UART: 3.3V, TX, RX, GND / 56700 8N1 / only pads on PCB
- micro USB input (for power only)
- reset button
- FCC ID: 2AXH6CREALITY-BOX

MAC addresses as verified by OEM firmware:
vendor   OpenWrt    source
LAN      eth0       factory 0x2e
2.4GHz   phy0-ap0   factory 0x04 (label)

LEDs
color    vendor                OpenWRT     configurable
red      SD card activity        -             yes
green    Cloud connectivity    status          yes
blue     LAN activity          eth0            yes
yellow   WIFI activity         phy0tpt         yes

Return to OEM & debrick
- download "cxsw_update.tar.bz2" from manufacturer site
- extract archive to FAT32 USB stick root
- put USB stick in USB2 port
- press & hold reset button
- power on device while holding reset
- wait approx 10 sec
- release reset button

Installation with SD Card
- power on device
- wait for device to finish starting
- copy "openwrt-ramips-mt76x8-creality_wb-01-squashfs-cxsw_update.tar.bz2"
  to root of FAT32 SD card
- rename openwrt-ramips-mt76x8-creality_wb-01-squashfs-cxsw_update.tar.bz2
  to "cxsw_update.tar.bz2"
- put SD card in device
- device will install OpenWRT on internal flash

Installation via telnet:
- extract the "factory.bin" and "install.sh" from newly created
  openwrt-ramips-mt76x8-creality_wb-01-squashfs-cxsw_update.tar.bz2
  to FAT32 USB stick root
- telnet to 10.10.10.254, user: root, password: cxswprin
- plug the USB in USB1 port
- cd /media/usbdisk/
- sh install.sh
- device will write "factory.bin" to internal flash

Co-authored-by: George Brooke <figgyc@figgyc.uk>
Signed-off-by: Peca Nesovanovic <peca.nesovanovic@sattrakt.com>
@Npeca75
Copy link
Author

Npeca75 commented Apr 14, 2024

@shivajiva101

Don't be silly I want the PR merged.
your last push looks okay to me

would you please review and approve this PR ?

@rmilecki
may i ask you to finish review of this PR ?

@shivajiva101
Copy link

@Npeca75 I don't have write access so I can't be of any help to you in that respect. Can the blue led be configured as link on, transmit & receive to reflect the status on that interface as the default behaviour?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target/ramips pull request/issue for ramips target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants