Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.05] ipq40xx: convert Engenius EAP1300 to DSA #15402

Merged
merged 4 commits into from
May 12, 2024

Conversation

ryancdotorg
Copy link
Contributor

This is just the commits from #15358 cherry-picked against openwrt-23.05.

@github-actions github-actions bot added kernel pull request/issue with Linux kernel related changes target/ipq40xx pull request/issue for ipq40xx target release/23.05 pull request/issue targeted (also) for OpenWrt 23.05 release labels May 6, 2024
Copy link
Contributor

@cminyard cminyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks correct to me. I have tested these exact changes (though I did the porting by hand and not from here) and they work without issue.

@ryancdotorg ryancdotorg changed the title ipq40xx: convert Engenius EAP1300 to DSA (23.05) [23.05] ipq40xx: convert Engenius EAP1300 to DSA May 7, 2024
@robimarko
Copy link
Contributor

I will let CI take a pass at rebased tree and merge if it passes as it seems OK to me

@ryancdotorg
Copy link
Contributor Author

Thank you, Rob, I appreciate this.

It's needed to get the MAC addresses for the Engenius EAP1300.

Signed-off-by: Corey Minyard <minyard@acm.org>
Link: openwrt#15358
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Link: openwrt#15402
Signed-off-by: Robert Marko <robimarko@gmail.com>
This commit converts the EAP1300 to DSA setup.

Signed-off-by: Corey Minyard <minyard@acm.org>
Link: openwrt#15358
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Link: openwrt#15402
Signed-off-by: Robert Marko <robimarko@gmail.com>
The code that was there was just taking whatever was left in the
registers, which was just wrong.  Set the addresses using the value from
the u-boot environment, the same way the OEM firmware does.

Signed-off-by: Corey Minyard <minyard@acm.org>
Link: openwrt#15358
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Link: openwrt#15402
Signed-off-by: Robert Marko <robimarko@gmail.com>
Now that DSA is enabled and the MAC addresses are set properly, we can
use it.

Signed-off-by: Corey Minyard <minyard@acm.org>
Link: openwrt#15358
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Link: openwrt#15402
Signed-off-by: Robert Marko <robimarko@gmail.com>
@openwrt-bot openwrt-bot merged commit 7a0d5a5 into openwrt:openwrt-23.05 May 12, 2024
3 checks passed
@robimarko
Copy link
Contributor

Thanks! Rebased on top of openwrt-23.05 and merged!

ryancdotorg pushed a commit to ryancdotorg/openwrt that referenced this pull request May 13, 2024
Now that DSA is enabled and the MAC addresses are set properly, we can
use it.

Signed-off-by: Corey Minyard <minyard@acm.org>
Link: openwrt#15358
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Link: openwrt#15402
Signed-off-by: Robert Marko <robimarko@gmail.com>
wang1zhen pushed a commit to wang1zhen/openwrt that referenced this pull request May 23, 2024
It's needed to get the MAC addresses for the Engenius EAP1300.

Signed-off-by: Corey Minyard <minyard@acm.org>
Link: openwrt/openwrt#15358
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Link: openwrt/openwrt#15402
Signed-off-by: Robert Marko <robimarko@gmail.com>
wang1zhen pushed a commit to wang1zhen/openwrt that referenced this pull request May 23, 2024
This commit converts the EAP1300 to DSA setup.

Signed-off-by: Corey Minyard <minyard@acm.org>
Link: openwrt/openwrt#15358
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Link: openwrt/openwrt#15402
Signed-off-by: Robert Marko <robimarko@gmail.com>
wang1zhen pushed a commit to wang1zhen/openwrt that referenced this pull request May 23, 2024
The code that was there was just taking whatever was left in the
registers, which was just wrong.  Set the addresses using the value from
the u-boot environment, the same way the OEM firmware does.

Signed-off-by: Corey Minyard <minyard@acm.org>
Link: openwrt/openwrt#15358
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Link: openwrt/openwrt#15402
Signed-off-by: Robert Marko <robimarko@gmail.com>
wang1zhen pushed a commit to wang1zhen/openwrt that referenced this pull request May 23, 2024
Now that DSA is enabled and the MAC addresses are set properly, we can
use it.

Signed-off-by: Corey Minyard <minyard@acm.org>
Link: openwrt/openwrt#15358
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Link: openwrt/openwrt#15402
Signed-off-by: Robert Marko <robimarko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel pull request/issue with Linux kernel related changes release/23.05 pull request/issue targeted (also) for OpenWrt 23.05 release target/ipq40xx pull request/issue for ipq40xx target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants