-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[23.05] ipq40xx: convert Engenius EAP1300 to DSA #15402
[23.05] ipq40xx: convert Engenius EAP1300 to DSA #15402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks correct to me. I have tested these exact changes (though I did the porting by hand and not from here) and they work without issue.
83ef02d
to
c20ee9f
Compare
I will let CI take a pass at rebased tree and merge if it passes as it seems OK to me |
Thank you, Rob, I appreciate this. |
It's needed to get the MAC addresses for the Engenius EAP1300. Signed-off-by: Corey Minyard <minyard@acm.org> Link: openwrt#15358 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Link: openwrt#15402 Signed-off-by: Robert Marko <robimarko@gmail.com>
This commit converts the EAP1300 to DSA setup. Signed-off-by: Corey Minyard <minyard@acm.org> Link: openwrt#15358 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Link: openwrt#15402 Signed-off-by: Robert Marko <robimarko@gmail.com>
The code that was there was just taking whatever was left in the registers, which was just wrong. Set the addresses using the value from the u-boot environment, the same way the OEM firmware does. Signed-off-by: Corey Minyard <minyard@acm.org> Link: openwrt#15358 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Link: openwrt#15402 Signed-off-by: Robert Marko <robimarko@gmail.com>
Now that DSA is enabled and the MAC addresses are set properly, we can use it. Signed-off-by: Corey Minyard <minyard@acm.org> Link: openwrt#15358 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Link: openwrt#15402 Signed-off-by: Robert Marko <robimarko@gmail.com>
c20ee9f
to
7a0d5a5
Compare
Thanks! Rebased on top of openwrt-23.05 and merged! |
Now that DSA is enabled and the MAC addresses are set properly, we can use it. Signed-off-by: Corey Minyard <minyard@acm.org> Link: openwrt#15358 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Link: openwrt#15402 Signed-off-by: Robert Marko <robimarko@gmail.com>
It's needed to get the MAC addresses for the Engenius EAP1300. Signed-off-by: Corey Minyard <minyard@acm.org> Link: openwrt/openwrt#15358 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Link: openwrt/openwrt#15402 Signed-off-by: Robert Marko <robimarko@gmail.com>
This commit converts the EAP1300 to DSA setup. Signed-off-by: Corey Minyard <minyard@acm.org> Link: openwrt/openwrt#15358 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Link: openwrt/openwrt#15402 Signed-off-by: Robert Marko <robimarko@gmail.com>
The code that was there was just taking whatever was left in the registers, which was just wrong. Set the addresses using the value from the u-boot environment, the same way the OEM firmware does. Signed-off-by: Corey Minyard <minyard@acm.org> Link: openwrt/openwrt#15358 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Link: openwrt/openwrt#15402 Signed-off-by: Robert Marko <robimarko@gmail.com>
Now that DSA is enabled and the MAC addresses are set properly, we can use it. Signed-off-by: Corey Minyard <minyard@acm.org> Link: openwrt/openwrt#15358 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Link: openwrt/openwrt#15402 Signed-off-by: Robert Marko <robimarko@gmail.com>
This is just the commits from #15358 cherry-picked against openwrt-23.05.