ipq806x: Meraki MR52: swap lan leds #15410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be |
namiltd
changed the title
|
Can change and move the tag Fixes issue to Fixes and put it right up the SoB tag. Also can you change the commit message to something more descriptive like "LAN Leds on Meraki MR52 are wrong and needs to be swapped to actually reflect real ports" |
namiltd
force-pushed
the
patch-4
branch
3 times, most recently
from
8d2885a
to
41800e1
Compare
Ansuel
pushed a commit
to namiltd/openwrt
that referenced
this pull request
May 7, 2024
LAN Leds on Meraki MR52 are wrong and needs to be swapped to actually reflect real ports (lan1<->lan2). Fixes: openwrt#15388 Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com> Link: openwrt#15410 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Ansuel
pushed a commit
to namiltd/openwrt
that referenced
this pull request
May 7, 2024
LAN Leds on Meraki MR52 are wrong and needs to be swapped to actually reflect real ports (lan1<->lan2). Fixes: openwrt#15388 Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com> Link: openwrt#15410 [ wrap commit to 80 columns and improve commit title ] Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Ansuel
pushed a commit
to namiltd/openwrt
that referenced
this pull request
May 7, 2024
LAN Leds on Meraki MR52 are wrong and needs to be swapped to actually reflect real ports (lan1<->lan2). Fixes: openwrt#15388 Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com> Link: openwrt#15410 [ wrap commit to 80 columns and improve commit title ] Link: openwrt#15410 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
LAN Leds on Meraki MR52 are wrong and needs to be swapped to actually reflect real ports (lan1<->lan2). Fixes: openwrt#15388 Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com> Link: openwrt#15410 [ wrap commit to 80 columns and improve commit title ] Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
|
@namiltd guess this should be also backported? |
openwrt-bot
pushed a commit
that referenced
this pull request
May 7, 2024
LAN Leds on Meraki MR52 are wrong and needs to be swapped to actually reflect real ports (lan1<->lan2). Fixes: #15388 Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com> Link: #15410 [ wrap commit to 80 columns and improve commit title ] Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> (cherry picked from commit bd68521)
|
@Ansuel Yes, the fix was tested on 23.05.3. |
Vladdrako
pushed a commit
to Vladdrako/openwrt
that referenced
this pull request
May 18, 2024
LAN Leds on Meraki MR52 are wrong and needs to be swapped to actually reflect real ports (lan1<->lan2). Fixes: openwrt#15388 Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com> Link: openwrt#15410 [ wrap commit to 80 columns and improve commit title ] Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LAN Leds on Meraki MR52 are wrong and needs to be swapped to actually reflect real ports (lan1<->lan2).
Fixes: #15388