Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipq40xx: use existing upstream node labels #15415

Merged
merged 11 commits into from
May 9, 2024

Conversation

robimarko
Copy link
Contributor

There are a lot of boards in ipq40xx that still manually define nodes under soc node for things that upstream already has existing labels so this PR converts all of them and fixes some weird stuff found along the way.

@github-actions github-actions bot added the target/ipq40xx pull request/issue for ipq40xx target label May 7, 2024
@john-tho
Copy link
Contributor

john-tho commented May 7, 2024

Good cleanup.


I see in some of these DTS declarations for the SoC global counter, but have not seen a driver in Linux or Openwrt. These do anything, or another downstream relic?

		counter@4a1000 {
			compatible = "qcom,qca-gcnt";
			reg = <0x4a1000 0x4>;
		};

@robimarko
Copy link
Contributor Author

Good cleanup.

I see in some of these DTS declarations for the SoC global counter, but have not seen a driver in Linux or Openwrt. These do anything, or another downstream relic?

		counter@4a1000 {
			compatible = "qcom,qca-gcnt";
			reg = <0x4a1000 0x4>;
		};

This counter exists in the SoC, but it never had a driver that would expose it so its mostly just for documentation purposes.

@robimarko
Copy link
Contributor Author

@Ansuel Can you take a sanity check look?

@Ansuel
Copy link
Member

Ansuel commented May 8, 2024

Good cleanup.

I see in some of these DTS declarations for the SoC global counter, but have not seen a driver in Linux or Openwrt. These do anything, or another downstream relic?

		counter@4a1000 {
			compatible = "qcom,qca-gcnt";
			reg = <0x4a1000 0x4>;
		};

This counter exists in the SoC, but it never had a driver that would expose it so its mostly just for documentation purposes.

I wonder what would be the usage?

@robimarko
Copy link
Contributor Author

I wonder what would be the usage?

No idea really

Currently, a lot of boards are still not using the existing label to
reference the watchdog node, so lets rectify this.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
Currently, a lot of boards are still not using the existing label to
reference the prng node, so lets rectify this.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
Currently, a lot of boards are still not using the existing label to
reference the crypto node, so lets rectify this.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
WPJ419 is still manually defining dma nodes(And even some labels), so lets
convert it to use the existing upstream labels for DMA nodes.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
This device does not have NAND enabled at all and NAND is the only consumer
of QPIC BAM DMA, so drop the node.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
Some boards are still defininig UART nodes under soc instead of using the
existing upstream labels to reference them so convert them.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
Some boards are still defininig I2C nodes under soc instead of using the
existing upstream labels to reference them so convert them.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
Some boards are still defining MDIO nodes under soc instead of using the
existing upstream labels to reference them so convert them.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
WPJ419 is still manually defining PCIe node, so lets
convert it to use the existing upstream labels for PCIe node and while we
are here use the -gpios suffix instead.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
WPJ419 is still manually defining pinctrl node, so lets
convert it to use the existing upstream labels for pinctrl node.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
WPJ419 is still manually defining SPI node, so lets
convert it to use the existing upstream labels for SPI node.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
@openwrt-bot openwrt-bot merged commit 592b6aa into openwrt:main May 9, 2024
3 checks passed
@robimarko
Copy link
Contributor Author

Thanks! Rebased on top of main and merged!

@robimarko robimarko deleted the dts-labels branch May 9, 2024 08:12
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request May 18, 2024
Currently, a lot of boards are still not using the existing label to
reference the watchdog node, so lets rectify this.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request May 18, 2024
Currently, a lot of boards are still not using the existing label to
reference the prng node, so lets rectify this.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request May 18, 2024
Currently, a lot of boards are still not using the existing label to
reference the crypto node, so lets rectify this.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request May 18, 2024
WPJ419 is still manually defining dma nodes(And even some labels), so lets
convert it to use the existing upstream labels for DMA nodes.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request May 18, 2024
This device does not have NAND enabled at all and NAND is the only consumer
of QPIC BAM DMA, so drop the node.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request May 18, 2024
Some boards are still defininig UART nodes under soc instead of using the
existing upstream labels to reference them so convert them.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request May 18, 2024
Some boards are still defininig I2C nodes under soc instead of using the
existing upstream labels to reference them so convert them.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request May 18, 2024
Some boards are still defining MDIO nodes under soc instead of using the
existing upstream labels to reference them so convert them.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request May 18, 2024
WPJ419 is still manually defining PCIe node, so lets
convert it to use the existing upstream labels for PCIe node and while we
are here use the -gpios suffix instead.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request May 18, 2024
WPJ419 is still manually defining pinctrl node, so lets
convert it to use the existing upstream labels for pinctrl node.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request May 18, 2024
WPJ419 is still manually defining SPI node, so lets
convert it to use the existing upstream labels for SPI node.

Link: openwrt#15415
Signed-off-by: Robert Marko <robimarko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target/ipq40xx pull request/issue for ipq40xx target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants