[23.05] ipq40xx: whw03v2: backport RGB LED fixes #15438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kernel
1 task
The RGB LED should glow green in the 'running' state, but it was glowing cyan because the blue component defaulted to 'on'. Signed-off-by: Rodrigo Balerdi <lanchon@gmail.com> (cherry picked from commit fc62d66) Link: openwrt#15438 Signed-off-by: Robert Marko <robimarko@gmail.com>
Change the RGB indicator LED color for the running state from green to blue. There are various reasons for this change: - In stock firmware, green means internet connection is up, red means it is down, and blue means indeterminate. To track stock behavior as closely as possible, OpenWrt should indicate blue by default. - In the current 23.x OpenWrt releases for this router, the led glows blue all the time -not green- because the bootloader sets it blue and there is an OpenWrt bug that makes it unable to control the LED. The bug is fixed in master, so without this commit there would be an unexpected change of behavior for this device in the next release. - The ports other closely related Linksys devices (such as EA8300 and MR8300) get this right and use blue for the running state. Signed-off-by: Rodrigo Balerdi <lanchon@gmail.com> (cherry picked from commit c2f52e4) Link: openwrt#15438 Signed-off-by: Robert Marko <robimarko@gmail.com>
robimarko
force-pushed
the
whw03v2-leds-23.05
branch
from
d435e7b
to
567af39
Compare
|
Thanks! Rebased on top of openwrt-23.05 and merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Ansuel
WHW03 V2 was unable to control its LEDs due to a bug.
as a workaround,
linux,default-trigger = "default-on";was added to its blue led in the DTS, to at least have a LED shining while the device was powered on. (otherwise the device would go totally dark.)now the LED bugfix was backported to 23.05 (7606dac), which means that the workaround has to be removed to restore good behavior.
thanks!