Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubnt-ledbar: adapt for kernel v6.6 #15443

Merged
merged 1 commit into from
May 11, 2024
Merged

Conversation

swegener
Copy link
Contributor

@swegener swegener commented May 10, 2024

Linux kernel commit torvalds/linux@b8a1a4c added a temporary probe_new member to struct i2c_driver, to drop the rarely used second parameter of the probe function and not break API for out of tree drivers. With torvalds/linux@5eb1e6e, which is part of v6.6, this probe_new member is dropped and the signature of the probe function is updated.

ubnt-ledbar is used by the mediatek and ramips targets and both have been updated to v6.6, so adapt the probe function signature and remove other compat code for versions before v6.6.

@robimarko
Copy link
Contributor

Considering that both mediatek and ramips targets are already on 6.6 only just update the driver to 6.6 standard as we dont need to support older kernels instead of keeping compatibility.

@swegener swegener changed the title ubnt-ledbar: add compat for kernel v6.6 ubnt-ledbar: adapt for kernel v6.6 May 10, 2024
@swegener
Copy link
Contributor Author

Was about to look at that, updated the commit to directly update the signature and remove other compat code.

@github-actions github-actions bot added the core packages pull request/issue for core (in-tree) packages label May 10, 2024
Linux kernel commit torvalds/linux@b8a1a4c
added a temporary probe_new member to struct i2c_driver, to drop the
rarely used second parameter of the probe function and not break API for
out of tree drivers. With torvalds/linux@5eb1e6e,
which is part of v6.6, this probe_new member is dropped and the
signature of the probe function is updated.

ubnt-ledbar is used by the mediatek and ramips targets and both have
been updated to v6.6, so adapt the probe function signature and remove
other compat code for versions before v6.6.

Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
Link: openwrt#15443
Signed-off-by: Robert Marko <robimarko@gmail.com>
@openwrt-bot openwrt-bot merged commit 0162174 into openwrt:main May 11, 2024
3 checks passed
@robimarko
Copy link
Contributor

Thanks! Rebased on top of main and merged!

Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request May 18, 2024
Linux kernel commit torvalds/linux@b8a1a4c
added a temporary probe_new member to struct i2c_driver, to drop the
rarely used second parameter of the probe function and not break API for
out of tree drivers. With torvalds/linux@5eb1e6e,
which is part of v6.6, this probe_new member is dropped and the
signature of the probe function is updated.

ubnt-ledbar is used by the mediatek and ramips targets and both have
been updated to v6.6, so adapt the probe function signature and remove
other compat code for versions before v6.6.

Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
Link: openwrt#15443
Signed-off-by: Robert Marko <robimarko@gmail.com>
@swegener swegener deleted the ubnt-ledbar-v6.6 branch June 23, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants