iproute2: update to 6.9.0 #15480
Merged
iproute2: update to 6.9.0 #15480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
core packages
|
iproute2/iproute2@69e3b2f needs to be backported as well. There are also time_t format errors. musl specific. |
|
Done @neheb, thanks for the review! |
rany2
force-pushed
the
iproute-gcc14
branch
3 times, most recently
from
9fefbd8
to
5e8b74c
Compare
|
I'll also mention this x86 specific failure: #15418 (comment) |
|
Oh, I did build test and it passed for arm; I'll try with x86 and let you know. I didn't check the thread for the PR that added support for GCC 14. |
|
@neheb It seems like the error in rdma was the last issue I needed to address, can you confirm this? |
neheb
approved these changes
May 13, 2024
|
Can you add a patch updating to 6.9.0? #15418 seems stalled. |
|
@neheb you mean you want this PR to also upgrade to 6.9.0? I'm willing to do so, just need a few hours |
|
Yeah. basically a second commit, |
|
@neheb I can't build |
|
sounds like something needs disabling. |
|
P.S. I think nothing was wrong on my end, it's just that ss now depends on libbpf: iproute2/iproute2@8740ca9 I'll fix this issue with that update to 6.9.0 you linked to now and update my PR. |
It's not stalled. You specifically mentioned it should be rebased on top of another pull request, so I'm waiting for it to get merged… EDIT: It's was actually this, but it was only build fixes for GCC 14. What happened here? |
|
@rsalvaterra I was asked to add your patch to update to 6.9.0. So the scope of the PR changed from just fixing compilation on GCC14 to that and also updating to 6.9.0. I also fixed building the |
|
That's strange, I had no issues building |
|
applied patch and built failed with gcc 14 |
|
@hingbong Can you upload your .config? |
here is the defconfig, maybe it's affected by something else |
|
@hingbong Sorry I don't have such a problem, I just did a completely clean build (distclean) and it built just fine. |
|
I updated this PR to use upstreamed version of the patch "bridge/vlan.c: bridge/vlan.c: fix build with gcc 14 on musl system". Edit: Also I did some renumbering in the initial "fix build on GCC 14" patch so I don't need to renumber on the "update to 6.9.0" commit |
|
@rany2 |
|
@httpstorm Isn't that addressed by f9d7404#diff-9292bf1ccdb9f0de893e4151a36b26639d117595e216c104516eb3b99cdd238f or are you referring to another instance of this? |
|
@rany2 |
|
@rany2 |
I've been using this for about a week now too so I think it's fine. I'm not really sure what I should do to get this merged. If you want you could test it out and if all looks good I'll add you in the Tested-by field. |
|
@rany2 |
I guess there's no need, my changes just involve adding missing includes and dependencies. |
Upstream patches: 401-bridge-vlan.c-bridge-vlan.c-fix-build-with-gcc-14-on.patch 402-bpf-fix-warning-from-basename.patch 403-bpf-include-libgen.h-for-basename.patch The patch (400-rdma-include-libgen.h-for-basename.patch) was not submitted upstream but just adds a missing include for basename. Signed-off-by: Rany Hany <rany_hany@riseup.net>
Support for iptables action has been dropped. Remove tc-mod-iptables and related
patch (175-reduce-dynamic-syms.patch).
We also add the missing libbpf dependency for `ss` since iproute 8740ca9
("ss: add support for BPF socket-local storage") now means that `ss` requires
libbpf as well.
Fix 170-ip_tiny.patch, as the help text didn't match all the included functions.
Drop upstreamed patches 402-bpf-fix-warning-from-basename.patch
and 403-bpf-include-libgen.h-for-basename.patch.
All other patches automatically rebased.
Co-authored-by: Rany Hany <rany_hany@riseup.net>
Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
Signed-off-by: Rany Hany <rany_hany@riseup.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iproute2: fix build on GCC 14
Upstream patches:
401-bridge-vlan.c-bridge-vlan.c-fix-build-with-gcc-14-on.patch
402-bpf-fix-warning-from-basename.patch
403-bpf-include-libgen.h-for-basename.patch
The patch (400-rdma-include-libgen.h-for-basename.patch) was not
submitted upstream but just adds a missing include for basename.
iproute2: update to 6.9.0
Support for iptables action has been dropped. Remove tc-mod-iptables and related
patch (175-reduce-dynamic-syms.patch).
We also add the missing libbpf dependency for
sssince iproute 8740ca9("ss: add support for BPF socket-local storage") now means that
ssrequireslibbpf as well.
Fix 170-ip_tiny.patch, as the help text didn't match all the included functions.
Drop upstreamed patches 402-bpf-fix-warning-from-basename.patch
and 403-bpf-include-libgen.h-for-basename.patch.
All other patches automatically rebased.