tools: refresh all patches #15524
Merged
tools: refresh all patches #15524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
build/scripts/tools
github-actions
bot
added
target/kirkwood
|
We actually do the same here but those packages depends on the target so they were never checked... for tools is should really check why the action doesn't work with checking to-refresh patches... |
|
I just noticed these lz4 patches are completely pointless. meson is used for lz4, not make. |
neheb
force-pushed
the
aggg
branch
2 times, most recently
from
3fcda1f
to
83aaa19
Compare
|
@Ansuel is this ready to go? |
|
@neheb I would ask just some additional hours or maybe a day... I just fixed a bug with tools/refresh and I introduced support for it in CI... Lets see how it goes! |
|
@neheb can I drop the packages commit and can we handle that in a different PR? |
|
OK |
|
@neheb maybe create a dedicated branch for the packages commit so you don't lose it? |
|
Yeah I got that. |
github-actions
bot
removed
target/kirkwood
github-actions
bot
removed
the
target/sifiveu
|
@Ansuel slight modification. Smaller refresh. |
meson is used to build it since 291b137. No need to patch Makefiles. Signed-off-by: Rosen Penev <rosenp@gmail.com> Link: openwrt#15524 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Refresh all tools patches now that tools/refresh correctly works. CI now checks for them and actively complain if tools have unrefreshed patches. Signed-off-by: Rosen Penev <rosenp@gmail.com> [ reword commit message ] Link: openwrt#15524 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Vladdrako
pushed a commit
to Vladdrako/openwrt
that referenced
this pull request
Jun 8, 2024
meson is used to build it since 291b137. No need to patch Makefiles. Signed-off-by: Rosen Penev <rosenp@gmail.com> Link: openwrt#15524 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Vladdrako
pushed a commit
to Vladdrako/openwrt
that referenced
this pull request
Jun 8, 2024
Refresh all tools patches now that tools/refresh correctly works. CI now checks for them and actively complain if tools have unrefreshed patches. Signed-off-by: Rosen Penev <rosenp@gmail.com> [ reword commit message ] Link: openwrt#15524 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI mandates clean patches in the packages feed but not here. Hrm.