Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uqmi: increased timeouts in qmi.sh #15530

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dr-ni
Copy link

@dr-ni dr-ni commented May 19, 2024

All uqmi calls have a timeout option -t to avoid hanging. The minimal timeout is increased now from 1 sec to 3 sec. This is more stable for modem startup.

@github-actions github-actions bot added the core packages pull request/issue for core (in-tree) packages label May 19, 2024
All uqmi calls have a timeout option -t to avoid hanging.
The minimal timeout is increased now from 1 sec to 3 sec.
This is more stable for modem startup.

Signed-off-by: Uwe Niethammer <uwe@dr-niethammer.de>
@mrkiko
Copy link
Contributor

mrkiko commented May 20, 2024

Well, I am under the impression the required timeout may be even longer and dependant on network conditions and other factors.
Do you think it would make sense to make this a variable?
Maybe even a configurable parameter, given the different environment on which a cellular modem can operate?

@dr-ni dr-ni mentioned this pull request May 20, 2024
@dr-ni
Copy link
Author

dr-ni commented May 20, 2024

The timeouts with 1 sec were discussed also before the last merge of my previous PR (#13781 (comment)).
I think larger timeouts should be doing the job since 3 seconds are already a quite long delay.
The main problem is still the unreliable uqmi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants