ipq40xx: dont panic on PSGMII calibration fail #15542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
target/ipq40xx
Currently, in case that PSGMII calibration fails it will panic the kernel which is not ideal and is preventing any debugging to be done. So, since PGMII calibration failing only means that wired networking wont work lets convet the panic() call to dev_error. Link: openwrt#15542 Signed-off-by: Robert Marko <robimarko@gmail.com>
robimarko
force-pushed
the
ipq40xx-psmgii-panic
branch
from
deb9793
to
4a78c46
Compare
|
Thanks! Rebased on top of main and merged! |
Vladdrako
pushed a commit
to Vladdrako/openwrt
that referenced
this pull request
Jun 8, 2024
Currently, in case that PSGMII calibration fails it will panic the kernel which is not ideal and is preventing any debugging to be done. So, since PGMII calibration failing only means that wired networking wont work lets convet the panic() call to dev_error. Link: openwrt#15542 Signed-off-by: Robert Marko <robimarko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in case that PSGMII calibration fails it will panic the kernel which is not ideal and is preventing any debugging to be done.
So, since PGMII calibration failing only means that wired networking wont work lets convet the panic() call to dev_error.