imagebuilder: fix broken IB_STANDALONE option #15599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynezz
reviewed
May 31, 2024
ynezz
reviewed
May 31, 2024
github-actions
bot
added
the
target/imagebuilder
Fix broken IB_STANDALONE option for OPKG due to an error in ifdef logic where we weren't adding the required entry to reference the local files in repositories.conf Rework the ifdef to more explicit and restore original functionality of this option. While at it also provide different README for APK or OPKG. Fixes: d788ab3 ("build: add APK package build capabilities") Link: openwrt#15599 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Vladdrako
pushed a commit
to Vladdrako/openwrt
that referenced
this pull request
Jun 8, 2024
Fix broken IB_STANDALONE option for OPKG due to an error in ifdef logic where we weren't adding the required entry to reference the local files in repositories.conf Rework the ifdef to more explicit and restore original functionality of this option. While at it also provide different README for APK or OPKG. Fixes: d788ab3 ("build: add APK package build capabilities") Link: openwrt#15599 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken IB_STANDALONE option for OPKG due to an error in ifdef logic where we weren't adding the required entry to reference the local files in repositories.conf
Rework the ifdef to more explicit and restore original functionality of this option.
While at it also provide different README for APK or OPKG.
Fixes: d788ab3 ("build: add APK package build capabilities")