"seq" tool check fixed #1926
Closed
"seq" tool check fixed #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedeckeh
added
build/scripts/tools
|
The PR has formal issues as it has no SoB; please read https://openwrt.org/submitting-patches. |
|
@dedeckeh hmm, I add signoff to comment, but can't make force push because pull request was made from github web ui I think. Is it enough? |
|
@imShara No it's not as the SoB needs to be added to the git commit description. You can do git commit --amend -s followed by git push -f |
|
Are you going to address the comments so we can move forward with this PR? |
Problem found on alpine linux when tried to `./scripts/feeds update -a` ```sh Build dependency: Missing seq command ``` Signed-off-by: imShara <shara@protonmail.com>
|
@dedeckeh ready to merge? |
Nope, you need to provide your real name in |
|
Pulled into my staging tree at https://git.openwrt.org/openwrt/staging/jow.git |
jow-
added a commit
that referenced
this pull request
Oct 18, 2019
Problem found on alpine linux when trying to `./scripts/feeds update -a`, which results in `Build dependency: Missing seq command`. Ref: #1926 Suggested-by: imShara <shara@protonmail.com> [reworded commit and turned faulty Sob into Suggested-by] Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jollaman999
pushed a commit
to jollaman999/openwrt
that referenced
this pull request
Oct 26, 2019
Problem found on alpine linux when trying to `./scripts/feeds update -a`, which results in `Build dependency: Missing seq command`. Ref: openwrt/openwrt#1926 Suggested-by: imShara <shara@protonmail.com> [reworded commit and turned faulty Sob into Suggested-by] Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem found on alpine linux when tried to
./scripts/feeds update -aBuild dependency: Missing seq commandSigned-off-by: Shara shara@protonmail.com