ath79: add support for KuWfi CPE830(D) / YunCore CPE830(D) #2297
Conversation
grosjo
force-pushed
the
kuwfi830
branch
9 times, most recently
from
e6daedb
to
41bb745
Compare
|
grosjo
force-pushed
the
kuwfi830
branch
4 times, most recently
from
4af08e8
to
402e417
Compare
There was a problem hiding this comment.
Some more suggestions below. They are valid for both boards.
You might have misunderstood my point about creating a shared dtsi a bit. If these boards are identical hardware wise, you can put all properties into a shared dtsi (except for the leds, aliases and model-/compatible strings).
Have a look at e.g. the D-Link DIR-842 family or the Devolo dvlxxxx at how this is done. 👍
grosjo
force-pushed
the
kuwfi830
branch
2 times, most recently
from
30f7b0a
to
60015da
Compare
As all those boards rely on AP147_010 design, I made a dtsi as such, and linked the yuncore and kuwfi on it |
|
Can you remove the LED definitions from your dtsi? I see it might be reused in other devices (which might not feature LEDs at all / different LEDs). Removing nodes in inheriting files is possible, thus the LED definition is something which should be set on a per-individual-device base. I've made two additional comments in out conversation above. |
cleaned up the leds |
@Neustradamus , @CodeFetch : as said several times already, this is totally and 100% pointless. THis block of LCD on the bottom or switch or F/N button are totally useless in OpenWrt setup. Only used in the crappy firmware shipped with th edevice, as WDS is handled differently in OpenWrt than in chinese firmware |
|
@grosjo Some people might want to use this switch and LCD display. |
|
No, because there are some things that need to be changed. Only proper device support will be merged. |
Then what are those "some things" ? THere is /nothing/ linked to the change request (as per Github) |
| model = "YunCore/KuWfi CPE830(D)"; | ||
|
|
||
| chosen { | ||
| bootargs = "console=ttyS0,115200 rootfstype=squashfs,jffs2 noinitrd"; |
| echo -n -e "YUNCOREsetenv bootcmd \"bootm 0x9f050000 || bootm 0x9fe80000\" &&" \ | ||
| "setenv resetcmd \"erase 0x9f050000 +0xfa0000 && cp.b 0x800600c0 0x9f050000 0xfa0000\" && \ | ||
| "setenv bootargs \"console=ttyS0,115200 rootfstype=squashfs,jffs2 noinitrd\" && \ | ||
| "saveenv && erase 0x9f050000 +0xfa0000 && cp.b 0x800600c0 0x9f050000 0xfa0000" | \ |
There was a problem hiding this comment.
DON'T USE MY CODE HERE AND WRONG!
| DEVICE_ALT0_MODEL = CPE830(D) | ||
| IMAGE_SIZE := 16000k | ||
| IMAGES += tftp.bin | ||
| IMAGE/tftp.bin := $$(IMAGE/sysupgrade.bin) | yuncore-tftp-header-qca953x |
There was a problem hiding this comment.
This PR is blocked until my PR is through
There was a problem hiding this comment.
So change your PR so it fits the needs not only your wishes
Keep on insulting people, this is very constructive..... |
|
No, buying one of these devices and doing an own PR would be constructive. |
What bullshit are you saying ? |
|
You do not listen. Thus it is wasted energy. |
Not planing to listen to someone insulting me at every line |
|
@grosjo What is really offensive is that you mark my review comments as resolved while they are not, that you use code from my PR without asking and that you always ask whether it can be merged to master while you know that only proper device support will be merged. Remember?
|
THis is totally bull Now, please, can you please act normally ? |
No, this is a good, technical explanation of why the bootcmd you define here is unnecessary. |
The REALITY is different than your THEORY What can I do ? keep supporting your harassment and try to change the reality (impossible, both cases) or just do what is right ? |
|
@grosjo
You have it twice here because of that. It's unneeded in your DTS, because it's already defined in the config file.
This is not the case here. Thus it does not do anything on this device and can be removed.
This is only needed if you have a UART console to set the baud rate and the serial device. As there is no UART device populated on the CPE830D, you can remove it. |
|
Don't care your philosophy command line : without it ,it fails noinitrd : why do you pre-suppose taht the kenerl is not compiled this or that way. "free will" is a concept that you have never heard of ? console : as mentionned so many times (too much actually) : some device DO HAVE a UART and some other DO NOT Can you please stop your harassment (it is , at least as the German court will define it) and act normally ? |
Then you need to find out why and do the elimination process (remove one bootcmd parameter after another until it doesn't boot anymore)
Ockham's razor... Why do you presume someone compiling the kernel this way?
CPE830 has, but not CPE830D
No, the German court wouldn't. They'd say I did not use insults and you could just have "moved away" if you've felt to be harassed. What is your problem actually? Please just test the changes, because your PR does not make sense at the moment. BTW I think the change pepe2k requested was: |
|
Not planning to kill other device (and loose additional money) on this topic, to "test" some of your "invention" So pissed by you, If you want people to conritbute to your project, don'tinsult them, that is the basic |
The worst thing that can happen is that the router denies installing the firmware.
Please show me the insult. I agree my stress levels are high. The most insulting thing that happened here is that you mark my reviews as resolved without doing changes. Edit: By the way I told you you need a SPI flasher if you work on a device without serial console and take flash dumps for recovery purposes before playing around with it. |
|
Have a good life |
|
Good luck! |
grosjo
force-pushed
the
kuwfi830
branch
2 times, most recently
from
3405a2b
to
98057fb
Compare
KuWfi CPE830(D) / YunCore CPE830(D) are same (rebranded) items of an outdoor
CPE/AP based on Qualcomm/Atheros QCA9531, using AP147 design.
Board uses ath9k driver (and not ath10k as previously stated in Openwrt)
Short specification:
- 650/600/216 MHz (CPU/DDR/AHB)
- 2x 10/100 Mbps Ethernet, passive PoE support
- 64 MB of RAM (DDR2)
- 16 MB of FLASH
- 2T2R 2.4 GHz with external PA, up to 30 dBm (1000mW)
- 2x internal 14 dBi antennas
- 8x LED (POWER/WLAN/WAN/LAN/4xRSSI), 1x button
- No UART on PCB on some versions
- Display panel with 2x buttons (F/N) not supported (and not relevant in OpenWrt)
Flash instruction
1. Connect PC with 192.168.0.141 to WAN port
2. Install a TFTP server on your PC ('atftp' is doing the job for instance)
3. Copy ./bin/targets/ath79/generic/openwrt-ath79-generic-yuncore_cpe830-squashfs-tftp.bin in the TFTP folder as upgrade.bin
4. Power up device pushing the 'reset' button
5. The device shall upload upgrade.bin, install it and reboot
6. Device shall be booting on 192.168.1.1 as default on LAN port (note : you need to change your cable from WAN to LAN)
Signed-off by: Joan Moreau <jom@grosjo.net>
KuWfi CPE830(D) / YunCore CPE830(D) are same (rebranded) items of an outdoor
CPE/AP based on Qualcomm/Atheros QCA9531, using AP147 design.
Board uses ath9k driver (and not ath10k as previously stated in Openwrt)
Short specification:
Flash instructions
Signed-off by: Joan Moreau jom@grosjo.net