-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: Remove some bashism #2647
Conversation
For commit messages like " |
If bashisms are to be removed, it makes sense to change the top shebang to point to /bin/sh as dash is faster than bash. edit: A moot point as these do not run on the host but it's still correct to add a shebang. |
@SvenRoederer Regarding "-a": |
a55ce50
to
9624548
Compare
@neheb I added the shebang to the files I edited. The scripts I edited are only running on the target-board, so /bin/sh links to busyboy-ash, right? @adrianschmutzler Regarding "-a": see 01c84b4 |
@SvenRoederer I think it will be more efficient if you already provide properly formatted patches in the first place. That will allow me to pick what's ready (or looks correct) right away. Currently, I would have to look at rather "trivial" patches several times, but I do not think this will benefit so much from having it pre-reviewed. |
c28a65d
to
93ce4d3
Compare
Ping. |
4b3dfee
to
3f7d2ae
Compare
@adrianschmutzler commits db23f92 , 38bebf5 , aeb858d , 0cc2d7c can be cherry-picked. The commits related to igmpproxy should be reviewed. |
Note that the author of your patches (From:) does not match your SOB. I corrected that manually for those patches already merged, but please take care of future patches yourself. |
Adding the shebang was based on this comment #2647 (comment). I changed my github settings, which hopefully improves the "From:" header. |
3f7d2ae
to
d62ebc6
Compare
"[[" is a bash extension for test. As the ash-implementation is not fully compatible we drop its usage. This follows up 3519bf4 Signed-off-by: Sven Roederer <devel-sven@geroedel.de>
d62ebc6
to
d05764c
Compare
as per https://patchwork.ozlabs.org/patch/1216221/ Signed-off-by: Sven Roederer <devel-sven@geroedel.de>
d05764c
to
57ed90a
Compare
@adrianschmutzler I just got a ping for this PR and reworked commits according to your comments. I also tested the change of the 2 commit to give the same results as the original. |
Hmm, just had another look and I still don't like it. The first commit tells to change brackets, but also changes &&/-a and -z/-n, only to have it changed again in the second commit. Please separate these changes properly. Despite, be aware that I'm treating this low-priority as it's cosmetic. Thanks for your work, however. |
I've squashed the two patches together with a slightly modified message and will merge them later today. |
Thanks for taking care.... I had it on my list with a list with a low priority ... |
This removes some non POSIX extensions from the shell-scripts, as already done in d6ac8ca. It targets "[[" and "==".