rbextract: support devices with plain RLE caldata #2731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschm
reviewed
Jan 31, 2020
rogerpueyo
force-pushed
the
rbextract-3-rle
branch
from
e4ac9ce
to
375d1b8
Compare
adschm
reviewed
Jan 31, 2020
|
Consider adding like "not merged yet" or similar to your Tested-by line, so it becomes obvious to the reader that you tested with a locally supported device. |
rogerpueyo
force-pushed
the
rbextract-3-rle
branch
from
375d1b8
to
ba6192c
Compare
Old MikroTik devices have the RLE-encoded radio calibration data directly stored in the art (hard_config) partition, without LZO compression nor any preceding ERD magic bytes. This commit adds a fallback for these devices. Tested on the ath79 target with a MikroTik SXT 5nD r2 (SXT Lite5), only locally --not yet merged upstream--. Signed-off-by: Roger Pueyo Centelles <roger.pueyo@guifi.net>
rogerpueyo
force-pushed
the
rbextract-3-rle
branch
from
ba6192c
to
4bec74f
Compare
|
lgtm |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very old MikroTik devices have the radio calibration data encoded in RLE and directly stored in the art (i.e., hard_config) partition, without LZO compression nor the preceding ERD magic bytes (which newer devices carry).
This commit adds a fallback for these devices: when no LZO or ERD magic bytes are read, assume raw RLE-encoded calibration data will follow.
Tested on the ath79 target with a MikroTik SXT 5nD r2 (SXT Lite5), which has the calibration data on the SPI NOR. The device is not yet supported though, as the NAND flash is not working yet.
Signed-off-by: Roger Pueyo Centelles roger.pueyo@guifi.net