uboot-sunxi: Banana Pi M2 Ultra switch to mainline defconfig #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynezz
added
target/sunxi
ynezz
reviewed
Mar 23, 2020
| @@ -294,7 +295,6 @@ UBOOT_TARGETS := \ | |||
| pangolin \ | |||
| pine64_plus \ | |||
| Sinovoip_BPI_M2_Plus \ | |||
There was a problem hiding this comment.
@CHKDSK88 BTW what about Sinovoip_BPI_M2_Plus ? Seems like it wont work these days.
ynezz@ntbk:/opt/devel/u-boot$ make Sinovoip_BPI_M2_Plus_config
***
*** Can't find default configuration "arch/../configs/Sinovoip_BPI_M2_Plus_defconfig"!
***
There was a problem hiding this comment.
This is a reason: u-boot/u-boot@268ae65
It should be changed if we bump uboot-sunxi to >=2019.04.
There was a problem hiding this comment.
@CHKDSK88 Thanks, should be fixed via ynezz@fefa6f5 as I plan to bump U-Boot to 2020.01 soon via ynezz@5cb06c0
There was a problem hiding this comment.
@ynezz
Thanks for info. LGTM.
At this moment, I can't run test it because my banana was burned.
I would remove this, that commit was probably fine as it just included that config in separate patch. |
U-boot also have defconfig for this board. In 2019.01 branch they are identical. Signed-off-by: Aleksander Jan Bajkowski <A.Bajkowski@stud.elka.pw.edu.pl>
abajk
force-pushed
the
bpi_m2_ultra_defc
branch
from
f0645d3
to
bb10f21
Compare
|
Thanks! Pulled into my staging tree at https://git.openwrt.org/openwrt/staging/ynezz.git |
jow-
pushed a commit
that referenced
this pull request
Mar 28, 2020
Rename the board as done in upstream commit 268ae6548779 ("sunxi: Rename
Sinovoip BPI M2 Plus to Bananapi M2 Plus H3") which backs the rename
with the following reasoning:
The brand Sinovoip is used for Sinovoip's original VOIP products, while
the Bananapi brand is for the single board computers they produce. This
has been verified by Bananapi. Rename the board from "Sinovoip BPI M2
Plus" to "Bananapi M2 Plus". For the defconfig file, all lowercase is
used.
To support the H5 variant of this board, the "H3" suffix is added to
the defconfig name.
This has to be done in order to allow building U-Boot past v2019.04
release where this change was introduced.
Ref: #2849 (comment)
Suggested-by: Pawel Dembicki <paweldembicki@gmail.com>
Signed-off-by: Petr Štetiar <ynezz@true.cz>
pull bot
pushed a commit
to zxlhhyccc/openwrt-sfe
that referenced
this pull request
Jul 10, 2020
Rename the board as done in upstream commit 268ae6548779 ("sunxi: Rename
Sinovoip BPI M2 Plus to Bananapi M2 Plus H3") which backs the rename
with the following reasoning:
The brand Sinovoip is used for Sinovoip's original VOIP products, while
the Bananapi brand is for the single board computers they produce. This
has been verified by Bananapi. Rename the board from "Sinovoip BPI M2
Plus" to "Bananapi M2 Plus". For the defconfig file, all lowercase is
used.
To support the H5 variant of this board, the "H3" suffix is added to
the defconfig name.
This has to be done in order to allow building U-Boot past v2019.04
release where this change was introduced.
Ref: openwrt/openwrt#2849 (comment)
Suggested-by: Pawel Dembicki <paweldembicki@gmail.com>
Signed-off-by: Petr Štetiar <ynezz@true.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
U-boot also have defconfig for this board. In 2019.01 branch they are identical.
Fixes: 26898a8
Signed-off-by: Aleksander Jan Bajkowski A.Bajkowski@stud.elka.pw.edu.pl