Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsmasq: 'ipset' config sections #3020

Closed
wants to merge 1 commit into from

Conversation

amezin
Copy link
Contributor

@amezin amezin commented May 13, 2020

Allow configuring ipsets with dedicated config sections:

config ipset
    list name 'ss_rules_dst_forward'
    list name 'ss_rules6_dst_forward'
    list domain 't.me'
    list domain 'telegram.org'

instead of rather inconvenient (especially with a long list of domain names):

config dnsmasq
    ...
    list ipset '/t.me/telegram.org/ss_rules_dst_forward,ss_rules6_dst_forward'

Old 'list ipset' way is still working.

Build & run tested: ipq806x/nbg6817

@amezin
Copy link
Contributor Author

amezin commented May 13, 2020

For more context: doing this after the discussion here: openwrt/packages#10979

@adschm adschm added core packages pull request/issue for core (in-tree) packages RFC pull request ready for comments labels May 14, 2020
@amezin amezin changed the title [RFC] dnsmasq: 'ipset' config sections dnsmasq: 'ipset' config sections Aug 24, 2020
Allow configuring ipsets with dedicated config sections:

    config ipset
        list name 'ss_rules_dst_forward'
        list name 'ss_rules6_dst_forward'
        list domain 't.me'
        list domain 'telegram.org'

instead of rather inconvenient (especially with a long list of domain names):

    config dnsmasq
        ...
        list ipset '/t.me/telegram.org/ss_rules_dst_forward,ss_rules6_dst_forward'

Now it should also be easier to implement a luci GUI for ipsets.

Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages RFC pull request ready for comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants