New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toolchain/gcc: Add GCC 10.1.0 #3126
Conversation
A bunch of packages should break with this :). I'll test when I can. |
For the patches dir part, please consider doing this in at least two separate commits, first a verbatim copy of the ones from 9.3.0, then changes in this addition, for ease of tracking and review. |
Commits I made to fix GCC 10 compilation: main repo: Luci: packages feed: wongsyrone/packages-1@56d9bc7 |
Locally libupnp is failing as well. GCC8 > 9 had less breakage. |
Sorry, I cannot fix the packages I didn't use. You can apply the porting guide GCC guys provided. I quote it here:
I think we should blame the package maintainer instead of a new compiler version enforcing C standard. |
Another casualty: openwrt/luci#4196 Those extern commits look weird to me. Should probably use static. edit: ah didn't realize you had the luci one in there. |
extern means the real definition locates in the corresponding source file instead of the header file. |
I found my patch listed on patchwork. |
Running this on an Archer C7v2. Works fine. malta works fine as well. |
Any update on this PR? |
I second that request which you've probably missed. It's hard to review (needs additional time) otherwise. |
No content changes in this commit Signed-off-by: Syrone Wong <wong.syrone@gmail.com>
Signed-off-by: Syrone Wong <wong.syrone@gmail.com>
Compared to GCC 9: 870-ppc_no_crtsavres.patch changes moved to another file following upstream 881-no_tm_section.patch keep the tm section disabled patches refreshed to apply cleanly See https://gcc.gnu.org/gcc-10/porting_to.html for more info Compiled and run tested on x86_64 Signed-off-by: Syrone Wong <wong.syrone@gmail.com>
Thanks! Pulled into my staging tree at https://git.openwrt.org/openwrt/staging/ynezz.git |
@ynezz Sorry. I cannot find my commits in your staging tree. |
IMPORTANT: I send this pull request because I can't see my patch listed on patchwork. This pull request is the same as the one sent to the mailing list.
Compared to GCC 9:
881-no_tm_section.patch modified based on upstream change
See https://gcc.gnu.org/gcc-10/porting_to.html for more info
Compiled and run tested on x86_64
Signed-off-by: Syrone Wong wong.syrone@gmail.com