Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolchain/gcc: Add GCC 10.1.0 #3126

Closed
wants to merge 3 commits into from

Conversation

wongsyrone
Copy link
Contributor

IMPORTANT: I send this pull request because I can't see my patch listed on patchwork. This pull request is the same as the one sent to the mailing list.

Compared to GCC 9:

881-no_tm_section.patch modified based on upstream change

See https://gcc.gnu.org/gcc-10/porting_to.html for more info

Compiled and run tested on x86_64

Signed-off-by: Syrone Wong wong.syrone@gmail.com

@wongsyrone
Copy link
Contributor Author

Cc @neheb @hauke @nbd168 @xback @yousong

@adschm adschm added the toolchain pull request/issue with toolchain related changes label Jun 21, 2020
@neheb
Copy link
Contributor

neheb commented Jun 21, 2020

A bunch of packages should break with this :). I'll test when I can.

@yousong
Copy link
Member

yousong commented Jun 22, 2020

For the patches dir part, please consider doing this in at least two separate commits, first a verbatim copy of the ones from 9.3.0, then changes in this addition, for ease of tracking and review.

@wongsyrone
Copy link
Contributor Author

@neheb
Copy link
Contributor

neheb commented Jun 22, 2020

Locally libupnp is failing as well. GCC8 > 9 had less breakage.

@wongsyrone
Copy link
Contributor Author

Sorry, I cannot fix the packages I didn't use. You can apply the porting guide GCC guys provided.

I quote it here:

As a workaround, legacy C code where all tentative definitions should be placed into a common block can be compiled with -fcommon.

I think we should blame the package maintainer instead of a new compiler version enforcing C standard.

@neheb
Copy link
Contributor

neheb commented Jun 22, 2020

Another casualty: openwrt/luci#4196

Those extern commits look weird to me. Should probably use static.

edit: ah didn't realize you had the luci one in there.

@wongsyrone
Copy link
Contributor Author

extern means the real definition locates in the corresponding source file instead of the header file.

@wongsyrone
Copy link
Contributor Author

I found my patch listed on patchwork.

@neheb
Copy link
Contributor

neheb commented Jun 22, 2020

Running this on an Archer C7v2. Works fine. malta works fine as well.

@wongsyrone
Copy link
Contributor Author

Any update on this PR?

@ynezz
Copy link
Member

ynezz commented Jul 7, 2020

For the patches dir part, please consider doing this in at least two separate commits, first a verbatim copy of the ones from 9.3.0, then changes in this addition, for ease of tracking and review.

I second that request which you've probably missed. It's hard to review (needs additional time) otherwise.

No content changes in this commit

Signed-off-by: Syrone Wong <wong.syrone@gmail.com>
Signed-off-by: Syrone Wong <wong.syrone@gmail.com>
Compared to GCC 9:

870-ppc_no_crtsavres.patch changes moved to another file following upstream
881-no_tm_section.patch keep the tm section disabled

patches refreshed to apply cleanly

See https://gcc.gnu.org/gcc-10/porting_to.html for more info

Compiled and run tested on x86_64

Signed-off-by: Syrone Wong <wong.syrone@gmail.com>
@wongsyrone
Copy link
Contributor Author

@ynezz @yousong Already split into three commits.

@ynezz
Copy link
Member

ynezz commented Jul 11, 2020

Thanks! Pulled into my staging tree at https://git.openwrt.org/openwrt/staging/ynezz.git

@ynezz ynezz closed this Jul 11, 2020
@wongsyrone
Copy link
Contributor Author

@ynezz Sorry. I cannot find my commits in your staging tree.

@wongsyrone wongsyrone deleted the update-gcc-10 branch July 12, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changes toolchain pull request/issue with toolchain related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants