Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: move package to packages.git #3351

Closed
wants to merge 1 commit into from
Closed

Conversation

aparcar
Copy link
Member

@aparcar aparcar commented Aug 26, 2020

curl is replaced by uclient-fetch within the OpenWrt build system and we
can therefore move curl to packages.git. This is based on the Hamburg
2019 decision that non essential packages should move outside base.

Signed-off-by: Paul Spooren mail@aparcar.org

Copy link
Member

@dangowrt dangowrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing seems to depend on curl any more (opkg used to use curl before we first switched to (busybox-)wget and later to uclient-fetch)

@dangowrt dangowrt requested review from kaloz and nbd168 August 26, 2020 18:45
@dedeckeh dedeckeh self-requested a review August 26, 2020 19:59
@dedeckeh
Copy link
Contributor

Package nghttp2 (https://github.com/openwrt/openwrt/tree/master/package/libs/nghttp2) can be moved as well to packages git as curl is the only package depending on it

@adschm adschm added the core packages pull request/issue for core (in-tree) packages label Aug 26, 2020
@aparcar
Copy link
Member Author

aparcar commented Aug 27, 2020

Faster than I though curl was moved over.... openwrt/packages#13214

curl is replaced by uclient-fetch within the OpenWrt build system and we
can therefore move curl to packages.git. This is based on the Hamburg
2019 decision that non essential packages should move outside base.

Signed-off-by: Paul Spooren <mail@aparcar.org>
@aparcar
Copy link
Member Author

aparcar commented Aug 27, 2020

Rebased...

@dedeckeh
Copy link
Contributor

@dedeckeh dedeckeh closed this Aug 27, 2020
@curtdept
Copy link
Contributor

curtdept commented Aug 28, 2020

For anyone who finds this, this change sucks for people with existing build dirs. make dirclean wont cleanout package/feeds or feeds directories in addition the package update doesn't place the new package files correctly this results in curl and libcurl "not found".

To complicate it, .config was also permanently modified to remove all related packages.

To work around rm -rf feeds and package/feeds and run normal scripts/feeds

@aparcar
Copy link
Member Author

aparcar commented Aug 28, 2020

@curtdept I removed the ./tmp folder, updated the feeds, install curl (this time the one from packages.git), make nconfig, select curl, compile

@curtdept
Copy link
Contributor

I had an existing dir, did a feeds, menuconfig, both complained of missing libcurl and curl. Then I thought old temp files somewhere, so I did a make dirclean, feeds, same thing.

until I wiped out feeds, started over and restored my .config it was stuck, seems fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants