New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl: move package to packages.git #3351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing seems to depend on curl
any more (opkg
used to use curl
before we first switched to (busybox-)wget
and later to uclient-fetch
)
Package nghttp2 (https://github.com/openwrt/openwrt/tree/master/package/libs/nghttp2) can be moved as well to packages git as curl is the only package depending on it |
Faster than I though |
curl is replaced by uclient-fetch within the OpenWrt build system and we can therefore move curl to packages.git. This is based on the Hamburg 2019 decision that non essential packages should move outside base. Signed-off-by: Paul Spooren <mail@aparcar.org>
Rebased... |
Patch pushed to master (https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=a5d030a54f671e52e4dd20460b350482a568ddb3); thx |
For anyone who finds this, this change sucks for people with existing build dirs. make dirclean wont cleanout package/feeds or feeds directories in addition the package update doesn't place the new package files correctly this results in curl and libcurl "not found". To complicate it, .config was also permanently modified to remove all related packages. To work around rm -rf feeds and package/feeds and run normal scripts/feeds |
@curtdept I removed the ./tmp folder, updated the feeds, install curl (this time the one from packages.git), make nconfig, select curl, compile |
I had an existing dir, did a feeds, menuconfig, both complained of missing libcurl and curl. Then I thought old temp files somewhere, so I did a make dirclean, feeds, same thing. until I wiped out feeds, started over and restored my .config it was stuck, seems fine now. |
curl is replaced by uclient-fetch within the OpenWrt build system and we
can therefore move curl to packages.git. This is based on the Hamburg
2019 decision that non essential packages should move outside base.
Signed-off-by: Paul Spooren mail@aparcar.org