Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ath10k-ct: fix compile without debugfs, 19.07 backport #3451

Closed
wants to merge 1 commit into from
Closed

ath10k-ct: fix compile without debugfs, 19.07 backport #3451

wants to merge 1 commit into from

Conversation

mkincaid
Copy link

@mkincaid mkincaid commented Sep 22, 2020

Currently ath10k-ct in the 19.07 branch fails to compile if CONFIG_PACKAGE_MAC80211_DEBUGFS is disabled.

This backports the upstream fix to v2019-09-09 of ath10k-ct used in 19.07.

@adschm
Copy link
Member

adschm commented Sep 25, 2020

The commit title prefix should be "ath10k-ct: " instead of "[kernel] ".

Apart from that, I assume that Eneas U de Queiroz is not an author of the OpenWrt patch, but just of the ath10k-ct patch? Because if yes, you should remove his Signed-off from the OpenWrt patch, and only use yours (but keep it in the ath10k-ct patch itself) ...

@adschm adschm added needs changes core packages pull request/issue for core (in-tree) packages release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release labels Sep 25, 2020
Currently ath10k-ct in the 19.07 branch fails to compile if
CONFIG_PACKAGE_MAC80211_DEBUGFS is disabled.

This backports the upstream fix to v2019-09-09 of ath10k-ct used in 19.07.

Signed-off-by: Michael Kincaid <mk+github@gbyt.co>

Origin: backport, greearb/ath10k-ct@ebe8143
@mkincaid mkincaid changed the title [kernel] backport fix for building ath10k-ct without debugfs to 19.07 ath10k-ct: fix compile without debugfs, 19.07 backport Sep 25, 2020
@hauke
Copy link
Member

hauke commented Feb 14, 2021

I do not see the compile error, I used this configuration in 19.07:

hauke@hauke-t480:~/openwrt/openwrt-19.07$ ./scripts/diffconfig.sh 
CONFIG_TARGET_ipq40xx=y
CONFIG_TARGET_ipq40xx_generic=y
CONFIG_TARGET_ipq40xx_generic_DEVICE_avm_fritzbox-7530=y
# CONFIG_PACKAGE_MAC80211_DEBUGFS is not set
hauke@hauke-t480:~/openwrt/openwrt-19.07$ grep ath10k-ct .config
CONFIG_DEFAULT_kmod-ath10k-ct=y
CONFIG_PACKAGE_kmod-ath10k-ct=y
# CONFIG_PACKAGE_kmod-ath10k-ct-smallbuffers is not set
hauke@hauke-t480:~/openwrt/openwrt-19.07$ ./scripts/getver.sh 
r11300-2eb8444363
hauke@hauke-t480:~/openwrt/openwrt-19.07$ 

@hauke
Copy link
Member

hauke commented Feb 14, 2021

Please provide the configuration where you see the problem.

@mkincaid
Copy link
Author

Can't reproduce from scratch; may have been caused by something wrong with my build environment before.

@mkincaid mkincaid closed this Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants