New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove uClibc-ng #3673
remove uClibc-ng #3673
Conversation
glibc 2.32 gained support for the ARC architecture. This is preparation for removing uClibc-ng. Signed-off-by: Rosen Penev <rosenp@gmail.com>
This is preparation for removing uClibc-ng. Signed-off-by: Rosen Penev <rosenp@gmail.com>
This is in preparation for removing it. Signed-off-by: Rosen Penev <rosenp@gmail.com>
After musl was introduced, it was desired to remove uClibc-ng. As ARC has no musl support, it was kept around. However, glibc 2.32 includes ARC support. This makes it possible to finally remove it. Signed-off-by: Rosen Penev <rosenp@gmail.com>
This sounds like something we should block until after the upcoming release? |
I don't recommend this merge.
|
1: This is not a question of performance |
I'm putting "blocked" label on this, as I don't think we should change this before the release. If somebody else feels differently, feel free to remove it again. Note that I'm totally in favor of the change in general, I'm just not sure whether we should do it now. (Unless uClibc-ng is broken in a way that it can only become better ...) |
Sure. To take devil's advocate, uClibc-ng currently compiles almost everything, according to the buildbots. glibc on the other hand fails with many packages. Mostly because of missing -lpthread. |
@adschm would you be open to a patch removing the !arc depend for GLIBC at least? |
Can't really say. I'd recommend to get a mood on this whole issue in IRC. |
I think removing uClibc-ng is a good thing, I do not see a big problem doing it before branching. We do not have many users of the ARC CPU targets and these are the only ones which should be affected. Maintaining uClibc-ng needs some efforts and we could reduce that. I do not see a big advantage of uClibc-ng over musl, glibc support is nice because it is the most used libc in the Linux world. @neheb Have you contacted Synopsys to test this on their devices? I would also like to have some more testing of the glibc, so having an unimportant target using it as default would be nice. |
I have not contacted Synopsis. I don't know what they think. |
@abrodkin thoughts? |
@curtdept it looks good to me and I may understand benefits of simplicity with removal of "extra" libc flavors. Especially if there're no other users of uClibc except ARC and uClibc is known to not be 100% compatible with glibc (and so here and there we saw breakages which needed attention).
But I guess it needs to be accommodated at some point anyways :) |
Thanks! Pulled into my staging tree at https://git.openwrt.org/openwrt/staging/ynezz.git |
Please do note that at the moment, only two glibc 32-bit ports support 64-bit time_t (ARC and RV32). So as @abrodkin mentions there might be some fallout if rest of OpenWRT is not prepared for this combination. e.g. Busybox upstream needed to adjusted. Just FYI. |
After musl was introduced, it was desired to remove uClibc-ng. As ARC
has no musl support, it was kept around. However, glibc 2.32 includes
ARC support. This makes it possible to finally remove it.
Signed-off-by: Rosen Penev rosenp@gmail.com