Openwrt 19.07 cudy WR1300 support #3725
Conversation
Signed-off-by: Sascha Effert <fermat@douglas2a.de>
Signed-off-by: Sascha Effert <fermat@douglas2a.de>
Currently it's not possible to tftpboot initramfs image on archer-c7-v5
as the image contains tplink-v1-header which leads to:
ath> bootm
## Booting image at 81000000 ...
Bad Magic Number
as U-Boot expects uImage wrapped image. This is caused by following
inheritance issue:
define Device/Init
KERNEL_INITRAMFS = $$(KERNEL)
define Device/tplink-v1
KERNEL := kernel-bin | append-dtb | lzma
KERNEL_INITRAMFS := kernel-bin | append-dtb | lzma | tplink-v1-header
define Device/tplink-safeloader
$(Device/tplink-v1)
define Device/tplink-safeloader-uimage
$(Device/tplink-safeloader)
KERNEL := kernel-bin | append-dtb | lzma | uImageArcher lzma
define Device/tplink_archer-c7-v5
$(Device/tplink-safeloader-uimage)
where tplink-v1 defines KERNEL_INITRAMFS with tplink-v1-header and it's
then used by all devices inheriting from tplink-safeloader. Fix this by
overriding KERNEL_INITRAMFS to KERNEL variable again.
Signed-off-by: Petr Štetiar <ynezz@true.cz>
(cherry picked from commit ceeece9)
Signed-off-by: Sascha Effert <fermat@douglas2a.de>
This brings in cudy WR-1300 support Signed-off-by: Sascha Effert <fermat@douglas2a.de>
|
"Thus, device support typically is not backported." |
|
"While feature backports still should be an exception, they typically are done for changes that are easy and well isolated. In contrast, requiring new drivers or patches to kernel subsystems etc. will drive your chances close to zero." I hoped that this is the case here... I signed off the commits now, I had forgotten to do this before. |
fermat2a
force-pushed
the
openwrt-19.07-cudy
branch
from
dd481db
to
66c1040
Compare
|
This has several formal issues, and adding a full DTS file is not simple/trivial in the original idea of that text. Apart from that, 19.07 has become quite old now, so your chances are virtually zero, particularly since you cannot present a strong argument to support your case. I won't merge it, and I don't think anybody else will. |
adschm
added
needs changes
release/19.07
|
o.k., understood.
Anyway I will go on with my work for the master Branch. Is there any idea about when the version 20 is planned? Is it enough to bring my changes into master to make it into the nexht version? Or is there already some stabi Branch against which I should also test?
Do you see anything I did wrong with this PR, that I should do better for the PR on master?
|
|
@fermat2a i'm not sure if it's written down, but having support in the master branch is crucial, otherwise it won't ever be acceptable for stable branches. so you (or the guys working on the patches) did it in the wrong order. |
|
Good to know. Is there already a way to test my changes against the ongoing work for release 20? I did not see a branch on github up to now.
|
|
no, as long as there is no branch, the work happens in master branch |
Adding support for AC1200 Dual Band Wi-Fi Router WR1300 into Openwrt 19.07 (http://www.cudytech.com/productinfo/90088.html).
Integration into master is in progress.