busybox: nslookup applet link with resolv if use glibc #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixed b36b8b6 ("busybox: remove nslookup_lede/openwrt.patch") It is likely dropped by mistake, This add back the changes Signed-off-by: Chen Minqiang <ptpt52@gmail.com>
|
wait, may be boot issue with this changes |
|
@aparcar build ok, but seems not work. boot failed with nslookup built-in |
|
Looking at the buildbot I don't see to many crashes... |
|
@aparcar tested ok on mt7622 the boot issue is somewhat issue with my build environment, I do a clean rebuild and everything works |
|
So there is no issue after all? Also do you use glibc for mt7622? In case this is resolved please close this issue. |
aparcar
referenced
this pull request
May 20, 2021
The nslookup_lede/openwrt applet was introduced in de5b8e5. It was introduced because: Add a new LEDE nslookup applet which is compatible with musl libc and providing more features like ability to specify query type. In contrast to busybox' builtin nslookup applet, this variant does not rely on libc resolver internals but uses explicit send logic and the libresolv primitives to parse received DNS responses. In busybox this applet is added in 0dd3be8. In particular, this commit introduces the variable NSLOOKUP_BIG. We set the default to true and so nothing changes. Signed-off-by: Nick Hainke <vincent@systemli.org>
|
This PR should be applied to fix build issue with glibc At first I thought that this changes caused the boot problem, but it turned out that there was no problem. This changes solved the issue of nslookup build failed with glibc. |
|
Can confirm, glibc builds broken on x86 and BCM2711 without the reference |
|
Tested and this fixes indeed the compilation, thank you very much. |
adschm
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed b36b8b6
("busybox: remove nslookup_lede/openwrt.patch")
It is likely dropped by mistake, This add back the changes