Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsmasq: add procd_jail for serversfile #4908

Closed
wants to merge 1 commit into from
Closed

dnsmasq: add procd_jail for serversfile #4908

wants to merge 1 commit into from

Conversation

stangri
Copy link
Member

@stangri stangri commented Dec 31, 2021 •
edited

If serversfile is outside of usual dnsmasq location make sure its
directory is added to procd_add_jail_mount.

Signed-off-by: Stan Grishin stangri@melmac.ca

@zdz2019
Copy link

zdz2019 commented Jan 1, 2022

Duplicate item: #4859

@stangri
Copy link
Member Author

stangri commented Jan 1, 2022

@zdz2019 thanks!
@alaviss if you're going to incorporate suggestion about mounting the directory and not the file directly, please let me know so I can close this, otherwise I will update my PR to include @dangowrt suggestion.

@alaviss
Copy link

alaviss commented Jan 1, 2022

Let's go with your PR instead

@alaviss alaviss mentioned this pull request Jan 1, 2022
Closed
@mans0n mans0n added the core packages pull request/issue for core (in-tree) packages label Jan 1, 2022
dangowrt
dangowrt reviewed Jan 4, 2022
View reviewed changes
Copy link
Member

@dangowrt dangowrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure that things don't break if people server option serversfile '/tmp/somefile' we may want to guard that case, mount only the file and warn the user.

package/network/services/dnsmasq/files/dnsmasq.init Outdated Show resolved Hide resolved
@stangri @dangowrt
dnsmasq: add procd_jail for serversfile
194e5f2 
If `serversfile` is outside of usual dnsmasq location make sure its
directory is added to `procd_add_jail_mount`.

Supercedes #4859

Signed-off-by: Stan Grishin <stangri@melmac.ca>
@stangri
Copy link
Member Author

stangri commented Mar 14, 2022

@dangowrt has this been merged? Can it be closed?

@stangri
Copy link
Member Author

stangri commented Aug 10, 2022

Running into issues with dnsmasq not being able to access the servers file indicated in settings with 22.03-rc6.

@jow- can this be picked up asap?

@dangowrt
Copy link
Member

dangowrt commented Aug 10, 2022 •
edited

@dangowrt has this been merged? Can it be closed?

0276fab has been merged instead and should be picked to openwrt-22.03 branch.

@stangri
Copy link
Member Author

stangri commented Aug 10, 2022

@dangowrt has this been merged? Can it be closed?

0276fab has been merged instead and should be picked to openwrt-22.03 branch.

Thanks for your prompt reply. The same jail expansion treatment needs to happen for addnhosts setting as well.

Can this be backported to 22.03? It's currently broken for simple-adblock package.

@dangowrt
Copy link
Member

Can this be backported to 22.03?

Done. 0179ba7

@stangri stangri closed this Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayface clayface clayface left review comments

@dangowrt dangowrt dangowrt left review comments

Assignees
No one assigned
Labels
core packages pull request/issue for core (in-tree) packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@stangri @zdz2019 @alaviss @dangowrt @clayface @mans0n