ramips: Add support command fw_setsys for Xiaomi routers #4936
Conversation
| @@ -73,6 +76,6 @@ zyxel,nr7101) | |||
| esac | |||
|
|
|||
| config_load ubootenv | |||
| config_foreach ubootenv_add_app_config ubootenv | |||
| config_foreach ubootenv_add_app_config | |||
There was a problem hiding this comment.
config_foreach with one argument looks wrong?
There was a problem hiding this comment.
It's not a wrong.
Look this: a3e9fd7#diff-3b87ce92c70f9b47215c6c7e7e0afbbe39c95e62b815935e95220dd12b124ca4
|
This has formal issues. Please use your real name for Signed-off-by and wrap you commit message so it has 74 chars. max per line. |
remittor
force-pushed
the
fw_setsys
branch
3 times, most recently
from
3342dc4
to
8ea952c
Compare
Fixed |
| xiaomi,redmi-router-ac2100) | ||
| ubootenv_add_uci_config "/dev/mtd1" "0x0" "0x1000" "0x20000" | ||
| ubootenv_add_uci_config "/dev/mtd1" "0x0" "0x1000" "0x10000" | ||
| ubootenv_add_uci_sys_config "/dev/mtd2" "0x0" "0x4000" "0x10000" |
There was a problem hiding this comment.
Maybe secsize for nand devices needs to be set to 0x20000 (128KiB) ?
There was a problem hiding this comment.
@remittor why from
ubootenv_add_uci_config "/dev/mtd1" "0x0" "0x1000" "0x20000"
to
ubootenv_add_uci_config "/dev/mtd1" "0x0" "0x1000" "0x10000"
There was a problem hiding this comment.
Because I don't want to break something on device xiaomi,mi-router-4a-gigabit (64 KiB sector)
There was a problem hiding this comment.
Ok lets think the opposite... Doesn't this cause problem for the other device that had 128KiB sectors?
Can't we just extend the switch and apply the correct sector based on the device to be extra safe?
There was a problem hiding this comment.
Can't we just extend the switch and apply the correct sector based on the device to be extra safe?
OK. Let's do that. Now I'll try to fix it.
|
Also don't know if |
|
@remittor Still interested in this? |
|
@remittor: Can you look? |
Yes |
The system parameters are contained in the Bdata partition. To use the fw_setsys command, you need to create a file fw_sys.config. This file is created after calling the functions ubootenv_add_uci_sys_config and ubootenv_add_app_config. Signed-off-by: Oleg S <remittor@gmail.com>
|
Thanks, merged in master with minor changes to commit description 6c7e337 |
This change was included in the original pull request but later omitted for some reason: openwrt#4936 Signed-off-by: Wenli Looi <wlooi@ucalgary.ca>
This change was included in the original pull request but later omitted for some reason: openwrt/openwrt#4936 Signed-off-by: Wenli Looi <wlooi@ucalgary.ca>
This change was included in the original pull request but later omitted for some reason: openwrt#4936 Signed-off-by: Wenli Looi <wlooi@ucalgary.ca>
This change was included in the original pull request but later omitted for some reason: openwrt#4936 Signed-off-by: Wenli Looi <wlooi@ucalgary.ca>
This change was included in the original pull request but later omitted for some reason: openwrt#4936 Signed-off-by: Wenli Looi <wlooi@ucalgary.ca>
The system parameters are contained in the
Bdatapartition.To use the
fw_setsyscommand, you need to create a filefw_sys.config. This file is created after calling the functionsubootenv_add_uci_sys_configandubootenv_add_app_config.