kexec-tools: issue warning when dd'ing vmcore #604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ffainelli Is this still good to go? Can you merge it please? |
|
Anyone? This is a pretty trivial fix. |
With no warning, it just looks like the box has hung during boot. We don't want users resetting it without having captured a crashdump. Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
pprindeville
force-pushed
the
kexec-dd-warning
branch
from
70da07d
to
32b509b
Compare
|
@pepe2k Can you please label this |
|
@dangowrt Can you please approve this? |
dangowrt
approved these changes
Feb 8, 2018
|
@pprindeville your comment history looks desperate |
|
merged, Thanks ! |
|
This was originally lede-project/source#1352 which was opened 5 months ago. It was approved almost immediately by @ffainelli, but not merged. It’s adding two trivial echos to a script. It shouldn’t be a controversial PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without giving a warning, it just looks like the box has hung during boot.
We don't want users resetting it without having captured a crashdump.
Signed-off-by: Philip Prindeville philipp@redfish-solutions.com