Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ar71xx: Fix 5 GHz Wi-Fi on NBG6716 #655

Closed
wants to merge 1 commit into from
Closed

ar71xx: Fix 5 GHz Wi-Fi on NBG6716 #655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion target/linux/ar71xx/base-files/etc/hotplug.d/firmware/11-ath10k-caldata
View file
Open in desktop
Expand Up @@ -18,12 +18,18 @@ ath10kcal_extract() {
local part=$1
local offset=$2
local count=$3
local mtd
local mtd cal_size

mtd=$(find_mtd_chardev $part)
[ -n "$mtd" ] || \
ath10kcal_die "no mtd device found for partition $part"

# Check that the calibration data size in header equals the desired size
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm worried about possible regression if we apply this check globally, for all boards.
Are you able point out any information about header layout and if it's the same for all ath10k chipsets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the header layout is the same for all current ath10k chips, both cal and pre-cal data. The same check is made in Qualcomm driver.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tell me where I can find it (link or what source file look into)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example https://git.kos.org.cn/openkos/qca-wifi/blob/master/qca-wifi/qca-wifi-10.2.4.58.1/offload/os/linux/tools/athdiag/qc98xx_eeprom.h look for base_eep_header.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!
I think it's safe to keep that check for all boards.

cal_size=$(dd if=$mtd bs=2 count=1 skip=$(( $offset / 2 )) conv=swab 2>/dev/null | hexdump -ve '1/2 "%d"')

[ "$count" = "$cal_size" ] || \
ath10kcal_die "no calibration data found in $part"

dd if=$mtd of=/lib/firmware/$FIRMWARE bs=1 skip=$offset count=$count 2>/dev/null || \
ath10kcal_die "failed to extract calibration data from $mtd"
}
Expand Down