Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base-files: Add support for OpenSSH sshd under failsafe #865

Closed
wants to merge 1 commit into from

Conversation

jeffsf
Copy link
Contributor

@jeffsf jeffsf commented Apr 12, 2018

Preserve ssh behavior under failsafe for ROMs without dropbear
but that do supply sshd and ssh-keygen. Password-less root login
is consistent with current dropbear behavior under failsafe.
sshd_config is created in /tmp/ and is not persisted.

OpenSSH sshd requires a valid date of last password. Confirmed
to work under failsafe when date is not set; 0 plus a few seconds.

Signed-off-by: Jeff Kletsky git-commits@allycomm.com

Preserve ssh behavior under failsafe for ROMs without dropbear
but that do supply sshd and ssh-keygen. Password-less root login
is consistent with current dropbear behavior under failsafe.
sshd_config is created in /tmp/ and is not persisted.

OpenSSH sshd requires a valid date of last password. Confirmed
to work under failsafe when date is not set; 0 plus a few seconds.

Signed-off-by: Jeff Kletsky <git-commits@allycomm.com>
@dedeckeh dedeckeh added the core packages pull request/issue for core (in-tree) packages label Apr 12, 2018
@jow-
Copy link
Contributor

jow- commented Apr 12, 2018

I'd prefer if the additional support code gets factored out into a separate /lib/preinit/... file which is bundled by the openssh-server package.

@jeffsf
Copy link
Contributor Author

jeffsf commented Apr 15, 2018

Looking at approaches to accomplish that. I assume you're asking for generic plug-in of the ssh server used in failsafe; dropbear, OpenSSH, or potentially others.

Now that I'll have to modify two or three different trees, what is the preferred method for submitting the patches?

@blogic
Copy link
Contributor

blogic commented Jul 30, 2018

@jeffsf best using the ML. please post V2 of the series there.

@blogic blogic closed this Jul 30, 2018
@jeffsf jeffsf deleted the openssh-in-failsafe branch May 17, 2019 17:07
kmcopper pushed a commit to kmcopper/packages that referenced this pull request Nov 26, 2019
Adds failsafe support to the openssh package.
Roughly based on an earlier patch.

Ref: openwrt/openwrt#865
Signed-off-by: Jeff Kletsky <git-commits@allycomm.com>
Signed-off-by: Kyle Copperfield <kmcopper@danwin1210.me>
kmcopper pushed a commit to kmcopper/packages that referenced this pull request Nov 28, 2019
Adds failsafe support to the openssh package.
Roughly based on an earlier patch.

Ref: openwrt/openwrt#865
Signed-off-by: Jeff Kletsky <git-commits@allycomm.com>
Signed-off-by: Kyle Copperfield <kmcopper@danwin1210.me>
kmcopper pushed a commit to kmcopper/packages that referenced this pull request Nov 28, 2019
Adds failsafe support to the openssh package.
Roughly based on an earlier patch.

Ref: openwrt/openwrt#865
Signed-off-by: Jeff Kletsky <git-commits@allycomm.com>
Signed-off-by: Kyle Copperfield <kmcopper@danwin1210.me>
kmcopper pushed a commit to kmcopper/packages that referenced this pull request Nov 28, 2019
Adds failsafe support to the openssh package.
Roughly based on an earlier patch.

Ref: openwrt/openwrt#865
Signed-off-by: Jeff Kletsky <git-commits@allycomm.com>
Signed-off-by: Kyle Copperfield <kmcopper@danwin1210.me>
kmcopper pushed a commit to kmcopper/packages that referenced this pull request Nov 28, 2019
Adds failsafe support to the openssh package.
Roughly based on an earlier patch.

Ref: openwrt/openwrt#865
Signed-off-by: Jeff Kletsky <git-commits@allycomm.com>
Signed-off-by: Kyle Copperfield <kmcopper@danwin1210.me>
kmcopper pushed a commit to kmcopper/packages that referenced this pull request Apr 19, 2020
Adds failsafe support to the openssh package.
Roughly based on an earlier patch.

Ref: openwrt/openwrt#865
Signed-off-by: Jeff Kletsky <git-commits@allycomm.com>
Signed-off-by: Kyle Copperfield <kmcopper@danwin1210.me>
kmcopper pushed a commit to kmcopper/packages that referenced this pull request Dec 15, 2020
Adds failsafe support to the openssh package.
Roughly based on an earlier patch.

Ref: openwrt/openwrt#865
Signed-off-by: Jeff Kletsky <git-commits@allycomm.com>
Signed-off-by: Kyle Copperfield <kmcopper@danwin1210.me>
kmcopper pushed a commit to kmcopper/packages that referenced this pull request Dec 15, 2020
Adds failsafe support to the openssh package.
Roughly based on an earlier patch.

Ref: openwrt/openwrt#865
Signed-off-by: Jeff Kletsky <git-commits@allycomm.com>
Signed-off-by: Kyle Copperfield <kmcopper@danwin1210.me>
kmcopper pushed a commit to kmcopper/packages that referenced this pull request Dec 15, 2020
Adds failsafe support to the openssh package.
Roughly based on an earlier patch.

Ref: openwrt/openwrt#865
Signed-off-by: Jeff Kletsky <git-commits@allycomm.com>
Signed-off-by: Kyle Copperfield <kmcopper@danwin1210.me>
kmcopper pushed a commit to kmcopper/packages that referenced this pull request Dec 15, 2020
Adds failsafe support to the openssh package.
Roughly based on an earlier patch.

Ref: openwrt/openwrt#865
Signed-off-by: Jeff Kletsky <git-commits@allycomm.com>
Signed-off-by: Kyle Copperfield <kmcopper@danwin1210.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants