Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove prerequisite ccache if CONFIG_CCACHE is unset #9479

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhanhb
Copy link
Contributor

@zhanhb zhanhb commented Mar 15, 2022

It's not necessary to compile ccache if CONFIG_SDK=y and CONFIG_CCACHE is not set when execute commands such as make tools/automake/compile.

@neheb
Copy link
Contributor

neheb commented Mar 15, 2022

I think the SDK is supposed to come with ccache included.

@zhanhb
Copy link
Contributor Author

zhanhb commented Mar 16, 2022

Yes. It's compile either CONFIG_SDK or CONFIG_CCACHE is defined. But only keep the prerequisite if CONFIG_CCACHE is defined.

@mans0n mans0n added the build/scripts/tools pull request/issues for build, scripts and tools related changes label Mar 16, 2022
@Ansuel
Copy link
Member

Ansuel commented Oct 6, 2022

@mpratt14 can you take a look at this?

@Ansuel Ansuel self-assigned this Oct 6, 2022
@mpratt14
Copy link
Contributor

mpratt14 commented Oct 6, 2022

the change is not bad but its arbitrary, why would you not want to use ccache if you're forced to build it anyway?

I think this can be resolved at command line

make tools/automake/compile CONFIG_CCACHE= CONFIG_SDK=

remove prerequisite ccache if CONFIG_CCACHE is unset

Signed-off-by: Huangbin Zhan <zhanhb88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/scripts/tools pull request/issues for build, scripts and tools related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants