uboot-lantiq: Add Arcadyan ARV7519RW22 support #9742
Conversation
howl
force-pushed
the
uboot-arv7519rw22
branch
4 times, most recently
from
80337e5
to
245cf3b
Compare
UBoot support for Arcadyan ARV7519RW22 with BRN, NOR and RAM variants. This code never landed but this is a must for the device to be supported. Some of Uboots overthere lack support for kernels above 2 MB, this solves raising it to 16 MB so image generation for the device could be renabled. Signed-off-by: David Santamaría Rogado <howl.nsp@gmail.com>
|
@mkresin to simplify the review process, this is the same code we used to generate the uboots we tested years ago with some minor changes. Defined ttyLTQ1 console that is not strictly needed, merged the environment for BRN BOOT with the NOR ones in the same if elif, and other changes to match the way some defines are in other xrx200 boards actually. Also ordered alphabetically BRN, NOR, RAM. |
|
Forget to mention if this could be also consider for 22.03. |
There was a problem hiding this comment.
Hi, another ARV7519RW22 user (not an openwrt developer) here. This PR looks reasonable, other than a few small things. We did the same on our own before finding your PR, and can confirm that u-boot now works with the current (22.03) OpenWRT release. It would be great to get this PR in!
| @@ -229,6 +229,25 @@ define U-Boot/easy50712_norspl | |||
| DEPENDS+=@BROKEN | |||
| endef | |||
|
|
|||
| define U-Boot/arv7519rw22_brn | |||
There was a problem hiding this comment.
The install instructions at https://openwrt.org/toh/arcadyan/arv7519rw22#installation explain how to use BRNBoot to flash the NOR version of U-boot. The BRN version of U-boot is most likely not needed. Has it been tested?
| +#endif | ||
| + | ||
| +#define GPIO_POWER_GREEN 14 | ||
| +#define GPIO_ALARM_BLUE 15 |
There was a problem hiding this comment.
Nitpick: When using a tab width of 8 spaces, the 15 is indented one tab too many compared to the 14.
| + gpio_direction_output(GPIO_POWER_GREEN, 0); | ||
| + | ||
| + /* Turn off the blue alarm LED */ | ||
| + gpio_direction_output(GPIO_ALARM_BLUE, 1); |
There was a problem hiding this comment.
Question: The patch in #1883 does additional configuration in this function:
/* EBU.FL_A23 as output for NOR flash */
gpio_set_altfunc(24, GPIO_ALTSEL_SET, GPIO_ALTSEL_CLR, GPIO_DIR_OUT);
/* EBU.FL_A24 as output for NOR flash */
gpio_set_altfunc(13, GPIO_ALTSEL_SET, GPIO_ALTSEL_CLR, GPIO_DIR_OUT);
/* EBU.FL_A25 as output for NOR flash */
gpio_set_altfunc(31, GPIO_ALTSEL_SET, GPIO_ALTSEL_CLR, GPIO_DIR_OUT);Is this important, or was it copy-pasta from some other device?
|
@Th3Fanbus sorry for replying you 10 months later, I'm don't think ARV7519RW22 is going to be ever merged in master as all PRs done haven't seen any love from main developers. |
UBoot for this device exists many years ago but haven't land here. This is also nowadays a previous step to renable images generation for the device as a 16 MB kernel size is defined.