Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: improve handling of AUTORELEASE #9893

Closed
wants to merge 1 commit into from

Conversation

aparcar
Copy link
Member

@aparcar aparcar commented May 16, 2022

No longer depend on specific commit subjects (containing "update to" or
"bump to") but instead look for changes of PKG_VERSION or
PKG_SOURCE_DATE.

Signed-off-by: Paul Spooren mail@aparcar.org

@mans0n mans0n added the build/scripts/tools pull request/issues for build, scripts and tools related changes label May 16, 2022
No longer depend on specific commit subjects (containing "update to" or
"bump to") but instead look for changes of `PKG_VERSION` or
`PKG_SOURCE_DATE`.

Signed-off-by: Paul Spooren <mail@aparcar.org>
@aparcar aparcar force-pushed the better-auto branch 2 times, most recently from 12f2c1f to 784a309 Compare May 16, 2022 18:01
@aparcar
Copy link
Member Author

aparcar commented May 16, 2022

Thanks to @jow- for the single line solution. You should try CodeGolf

@aparcar
Copy link
Member Author

aparcar commented May 17, 2022

@rsalvaterra @neheb cpuld you please give this a spin?

@xabolcs
Copy link
Contributor

xabolcs commented May 17, 2022

Thanks to jow- for the single line solution.

Suggested-by:? 😉

@rsalvaterra
Copy link
Member

Looks much saner, indeed. Will test.

@jefferyto
Copy link
Member

A few thoughts:

  • Perhaps it would be better to track PKG_SOURCE_VERSION instead of PKG_SOURCE_DATE, since PKG_SOURCE_DATE is not strictly required when using PKG_SOURCE_VERSION
  • If PKG_VERSION was moved but not changed, this would still be detected as a version change?
  • If a package version was defined with something like:
    MAJOR_VERSION:=1
    MINOR_VERSION:=0
    PKG_VERSION:=$(MAJOR_VERSION).$(MINOR_VERSION)
    
    then this would not detect any version changes?
  • Perhaps it would be better to include detecting changes to PKG_VERSION, etc. in addition to, instead of as a replacement for, detecting key phrases in the commit title (if this is possible)

@Ansuel
Copy link
Member

Ansuel commented Sep 13, 2022

@aparcar news on this?

@jefferyto in theory the PKG_RELEASE is used to detect changes on the package with the same version, am i wrong or changing PKG_VERSION would result in rebuilding the package and pushing a new version? (aka different PKG_VERSION with same PKG_RELEASE = new package anyway)

@Ansuel
Copy link
Member

Ansuel commented Jan 21, 2023

Closing this as AUTORELEASE is flagged as deprecated and should be dropped. Sad since it was a handy thing.

@Ansuel Ansuel closed this Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/scripts/tools pull request/issues for build, scripts and tools related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants