Skip to content

Commit

Permalink
acme-common: simplify config example
Browse files Browse the repository at this point in the history 
Make it more practical to easier get an idea

Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
  • Loading branch information
@stokito @tohojo
stokito authored and tohojo committed Mar 1, 2024
1 parent 4bec28b commit 04ac8c1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion net/acme-common/Makefile
View file
Expand Up @@ -8,7 +8,7 @@
include $(TOPDIR)/rules.mk

PKG_NAME:=acme-common
PKG_VERSION:=1.0.4
PKG_VERSION:=1.1.0

PKG_MAINTAINER:=Toke Høiland-Jørgensen <toke@toke.dk>
PKG_LICENSE:=GPL-3.0-only
Expand Down
10 changes: 5 additions & 5 deletions net/acme-common/files/acme.config
View file
Expand Up @@ -6,18 +6,18 @@ config cert 'example_wildcard'
option enabled 0
option staging 1
list domains example.org
list domains sub.example.org
list domains *.sub.example.org
list domains *.example.org
option validation_method dns
option dns "dns_freedns"
list credentials 'FREEDNS_User="ssladmin@example.org"'
list credentials 'FREEDNS_Password="1234"'
option calias "example.com"
option dalias "dalias.example.com"

config cert 'example'
config cert 'example_subdomain'
option enabled 0
option staging 1
list domains example.org
list domains sub.example.org
list domains example.net
list domains www.example.net
list domains mail.example.net
validation_method webroot

3 comments on commit 04ac8c1

@feckert
Copy link
Member

@feckert feckert commented on 04ac8c1 Mar 20, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tohojo Your change breaks the uci parser.
The problem I think is the * ?

Could you please put the uci configuration parameters in quotation marks?

Can you please fix this?

Command to verify the uci:
find /etc/config/* |while read output;do uci -q show $output > /dev/null||echo "Error in config \"$(basename $output)\"!";done

@feckert
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That´s the wrong line https://github.com/openwrt/packages/blob/master/net/acme-common/files/acme.config#L23

@tohojo
Copy link
Contributor

@tohojo tohojo commented on 04ac8c1 Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, pushed a fix

Please sign in to comment.