Skip to content

Commit

Permalink
qemu: ignore configure option --disable-ipv6
Browse files Browse the repository at this point in the history 
Fixes: #12194
Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
  • Loading branch information
@yousong
yousong committed May 20, 2020
1 parent 1091bad commit a303340
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions utils/qemu/Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@ CONFIGURE_ARGS:=$(filter-out \
--program-prefix=% \
--program-suffix=% \
--exec-prefix=% \
--disable-ipv6 \
--disable-nls \
, $(CONFIGURE_ARGS))

Expand Down

3 comments on commit a303340

@lucize
Copy link
Contributor

@lucize lucize commented on a303340 May 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yousong maybe a better way is this, so we have it enabled when ipv6 is available
$(if $(CONFIG_IPV6),,--disable-ipv6) \

@yousong
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yousong maybe a better way is this, so we have it enabled when ipv6 is available
$(if $(CONFIG_IPV6),,--disable-ipv6) \

Thanks for the advice. Unlikely to happen for qemu, but happy to add the guard just in case ;)

@yousong
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworked in ba6e5fc

Please sign in to comment.