Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openvswitch: [19.07] build fails with "too few arguments to function 'skb_dst" #10961

Closed
SvenRoederer opened this issue Jan 7, 2020 · 2 comments
Closed

openvswitch: [19.07] build fails with "too few arguments to function 'skb_dst" #10961

SvenRoederer opened this issue Jan 7, 2020 · 2 comments
Assignees
@yousong

Comments

@SvenRoederer
Copy link
Contributor

Maintainer: @yousong
Environment: (OpenWrt-19.07 release-tag)

Description: We build our firmware with CONFIG_KMOD_ALL enabled and the build fails with the following error:

  CC [M]  firmware/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/openvswitch-2.11.0/datapath/linux/ip_tunnel.o
firmware/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/openvswitch-2.11.0/datapath/linux/ip_tunnel.c: In function 'rpl_tnl_update_pmtu':
firmware/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/openvswitch-2.11.0/datapath/linux/ip_tunnel.c:269:3: error: too few arguments to function 'skb_dst((const struct sk_buff *)skb)->ops->update_pmtu'
   skb_dst(skb)->ops->update_pmtu(skb_dst(skb), NULL, skb, mtu);
   ^~~~~~~
make[8]: *** [scripts/Makefile.build:327: firmware/openwrt/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/openvswitch-2.11.0/datapath/linux/ip_tunnel.o] Error 1
@SvenRoederer SvenRoederer changed the title openvswitch: [19.07] build fails woth "too few arguments to function 'skb_dst" openvswitch: [19.07] build fails with "too few arguments to function 'skb_dst" Jan 7, 2020
@yousong yousong self-assigned this Jan 8, 2020
yousong added a commit that referenced this issue Jan 8, 2020
@yousong
openvswitch: fix building failure caused by dst_ops api change
7cc9c43 
Ref: #10961
Reported-by: Sven Roederer <devel-sven@geroedel.de>
Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
yousong added a commit that referenced this issue Jan 8, 2020
@yousong
openvswitch: fix building failure caused by dst_ops api change
74e160d 
Ref: #10961
Reported-by: Sven Roederer <devel-sven@geroedel.de>
Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
@yousong
Copy link
Member

yousong commented Jan 8, 2020

The issue should now be fixed in both master and openwrt-19.07 branch. Thanks for the heads-up

@SvenRoederer
Copy link
Contributor Author

Thanks, it's fixed for 19.07 with 74e160d. So I assume 7cc9c43 will do on master also.

SvenRoederer added a commit to freifunk-berlin/firmware that referenced this issue Jan 9, 2020
@SvenRoederer
Updating packages to yesterdays HEAD of openwrt-19.07
4de864f 
a4a54d0f3 openvswitch: bump to version 2.11.1
74e160df2 openvswitch: fix building failure caused by dst_ops api change
dc097661c openvswitch: backport patch to fix compilation
1f293771c openvswitch: bump PKG_RELEASE

This fixes build-failure caused by kmod-openvswitch (openwrt/packages#10961)
SvenRoederer added a commit to freifunk-berlin/firmware that referenced this issue Jan 10, 2020
@SvenRoederer
Updating packages to yesterdays HEAD of openwrt-19.07
3e92507 
a4a54d0f3 openvswitch: bump to version 2.11.1
74e160df2 openvswitch: fix building failure caused by dst_ops api change
dc097661c openvswitch: backport patch to fix compilation
1f293771c openvswitch: bump PKG_RELEASE

This fixes build-failure caused by kmod-openvswitch (openwrt/packages#10961)
SvenRoederer added a commit to freifunk-berlin/firmware that referenced this issue Jan 10, 2020
@SvenRoederer
Updating packages to yesterdays HEAD of openwrt-19.07
8324665 
a4a54d0f3 openvswitch: bump to version 2.11.1
74e160df2 openvswitch: fix building failure caused by dst_ops api change
dc097661c openvswitch: backport patch to fix compilation
1f293771c openvswitch: bump PKG_RELEASE

This fixes build-failure caused by kmod-openvswitch (openwrt/packages#10961)
SvenRoederer added a commit to SvenRoederer/freifunk-berlin-firmware that referenced this issue Feb 2, 2020
@SvenRoederer
Updating packages to yesterdays HEAD of openwrt-19.07
1fc9846 
a4a54d0f3 openvswitch: bump to version 2.11.1
74e160df2 openvswitch: fix building failure caused by dst_ops api change
dc097661c openvswitch: backport patch to fix compilation
1f293771c openvswitch: bump PKG_RELEASE

This fixes build-failure caused by kmod-openvswitch (openwrt/packages#10961)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yousong yousong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SvenRoederer @yousong