-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python-pynacl: compilation failed #13016
Comments
The only thing I have changed to upstream is, that I have applied my patch to move the pip-cache to tmp. |
I updated |
wait; that shouldn't matter; i updated cffi to 1.14.1 recently; but that's on the target-side; |
so, this patch in libsodium seems to have broken things here: 3ef28a4 we can probably patch this into PyNaCl, but I wouldn't enforce a solution; |
Should be fixed now. The problem was a missing autoreconf. edit: never mind. This package needs patching too. |
I think patching out all of the stub definitions in src/bindings/minimal/crypto_scalarmult.h and always setting I would have preferred variants for libsodium (#12902) but I see @neheb was the one who suggested changing the minimal build API 😦 |
Looks right. edit: I mentioned why I didn't like variants. They're a timing issue. |
I know - I got into an argument about variants and InstallDev a while ago (which I am not going to link to here 😂) I think the best solution is some kind of lib-switching mechanism in the main repo, where dependent packages can specify which variant they want and the right InstallDev files are switched/linked/etc. just for them, but I really don't have time to look into something so obscure right now 😂 |
Fixes openwrt#13016 Patch [1] broke compilation for python-pynacl. The fix is to patch PyNaCl to consider that PYNACL_HAS_CRYPTO_SCALARMULT_ED25519 is always available. [1] openwrt@3ef28a4 Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
PR #13033 |
Thanks all for the quick fix 👍 |
Fixes openwrt/packages#13016 Patch [1] broke compilation for python-pynacl. The fix is to patch PyNaCl to consider that PYNACL_HAS_CRYPTO_SCALARMULT_ED25519 is always available. [1] openwrt/packages@3ef28a4 Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Fixes openwrt#13016 Patch [1] broke compilation for python-pynacl. The fix is to patch PyNaCl to consider that PYNACL_HAS_CRYPTO_SCALARMULT_ED25519 is always available. [1] openwrt@3ef28a4 Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Fixes openwrt#13016 Patch [1] broke compilation for python-pynacl. The fix is to patch PyNaCl to consider that PYNACL_HAS_CRYPTO_SCALARMULT_ED25519 is always available. [1] openwrt@3ef28a4 Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Fixes openwrt#13016 Patch [1] broke compilation for python-pynacl. The fix is to patch PyNaCl to consider that PYNACL_HAS_CRYPTO_SCALARMULT_ED25519 is always available. [1] openwrt@3ef28a4 Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Functions from ed25519_core are needed for GNUnet to build. Include them in the minimal build of libsodium so we don't need to switch to the full build just for that. Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Maintainer: @jmarcet or @jefferyto
Environment: x86_64, APU3, openwrt master latest commit
Description:
I get the following output if I want to compile docker-compose.
It does work a view weeks ago, but suddenly after updateing the package feed I got the follwoing compil error.
I am not a python god and do not know what the problem is now!
I haven't read into the whole python build system of openwrt.
I don't know where to start. Is this a problem with the host, target or the pip?
Can anyone from the specialists @jefferyto or @commodo help me out?
The text was updated successfully, but these errors were encountered: