Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golang: shared build cache leads to dirty git status #13675

Closed
sch-m opened this issue Oct 15, 2020 · 2 comments
Closed

golang: shared build cache leads to dirty git status #13675

sch-m opened this issue Oct 15, 2020 · 2 comments

Comments

@sch-m
Copy link
Contributor

sch-m commented Oct 15, 2020

Maintainer: @jefferyto
Environment: x86_64, master

Description:
Commit 9074dbd moves to go build cache directory to $(TOPDIR)/.go-build by default, which leads to a dirty git status after build.
Wouldn't it be more appropriate to use $(BUILD_DIR_BASE)/.go-build?
@jefferyto jefferyto mentioned this issue Oct 16, 2020
Merged
@jefferyto
Copy link
Member

Thanks for logging this - $(BUILD_DIR_BASE)/.go-build would be my next choice but neither make clean nor make dirclean will remove it, so I have moved it to $(TMP_DIR)/go-build in #13681.

An existing build cache at $(TOP_DIR)/.go-build will need to be removed manually.

@sch-m
Copy link
Contributor Author

sch-m commented Oct 16, 2020

OK, thanks

@neheb neheb closed this as completed in b70fb40 Oct 16, 2020
pprindeville pushed a commit to pprindeville/packages that referenced this issue Dec 19, 2020
@jefferyto @pprindeville
golang: Move build cache into $(TMP_DIR)
e467756 
This changes the default build cache directory from $(TOPDIR)/.go-build
to $(TMP_DIR)/go-build, so that the cache directory is ignored by git
and is removed by "make dirclean".

This does not move/remove a build cache directory in the previous
location; it will need to be removed manually.

Fixes openwrt#13675.

Signed-off-by: Jeffery To <jeffery.to@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jefferyto @sch-m