iputils: incorrect version string #13920
Comments
nmeyerhans
added a commit
to nmeyerhans/packages
that referenced
this issue
Feb 3, 2021
The iputils build system embeds git tags into the generated binaries for use by commands like ping -V. Since openwrt packaging is done in a different repository from the upstream repo, the tags it finds aren't particularly meaningful, and we get confusing results like those described at openwrt#13920 This change removes the git tag inspection in favor of the static version string that's already known to the upstream build system. Signed-off-by: Noah Meyerhans <frodo@morgul.net>
nmeyerhans
added a commit
to nmeyerhans/packages
that referenced
this issue
Feb 3, 2021
The iputils build system embeds git tags into the generated binaries for use by commands like ping -V. Since openwrt packaging is done in a different repository from the upstream repo, the tags it finds aren't particularly meaningful, and we get confusing results like those described at openwrt#13920 This change removes the git tag inspection in favor of the static version string that's already known to the upstream build system. Signed-off-by: Noah Meyerhans <frodo@morgul.net>
nmeyerhans
added a commit
to nmeyerhans/packages
that referenced
this issue
Feb 3, 2021
The iputils build system embeds git tags into the generated binaries for use by commands like ping -V. Since openwrt packaging is done in a different repository from the upstream repo, the tags it finds aren't particularly meaningful, and we get confusing results like those described at openwrt#13920 This change removes the git tag inspection in favor of the static version string that's already known to the upstream build system. Signed-off-by: Noah Meyerhans <frodo@morgul.net>
|
Fixed with #14638 |
|
Even if we can’t keep the iputils git tag, can we keep the ‘s’ prefix to make it consistent with previous iputils versions and the prefix of iputils built on other systems? |
No. Ping has changed its versioning scheme upstream. This will propagate out to other distros and environments in time. |
|
When building from source on Ubuntu I get: Are you saying they changed the versioning again since then to remove the “s”? |
|
Yep! See their changelog entry. |
Got it. Thanks! |
1715173329
pushed a commit
to immortalwrt/packages
that referenced
this issue
Feb 4, 2021
The iputils build system embeds git tags into the generated binaries for use by commands like ping -V. Since openwrt packaging is done in a different repository from the upstream repo, the tags it finds aren't particularly meaningful, and we get confusing results like those described at openwrt/packages#13920 This change removes the git tag inspection in favor of the static version string that's already known to the upstream build system. Signed-off-by: Noah Meyerhans <frodo@morgul.net> Signed-off-by: Tianling Shen <cnsztl@project-openwrt.eu.org>
Grommish
pushed a commit
to Itus-Shield/packages
that referenced
this issue
Feb 15, 2021
The iputils build system embeds git tags into the generated binaries for use by commands like ping -V. Since openwrt packaging is done in a different repository from the upstream repo, the tags it finds aren't particularly meaningful, and we get confusing results like those described at openwrt#13920 This change removes the git tag inspection in favor of the static version string that's already known to the upstream build system. Signed-off-by: Noah Meyerhans <frodo@morgul.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Maintainer: @nmeyerhans
Ping from 20190709
Ping from 20200821
Downloaded from here:
http://downloads.openwrt.org/snapshots/packages/arm_cortex-a15_neon-vfpv4/packages/iputils-ping_20200821-1_arm_cortex-a15_neon-vfpv4.ipk
Ping from 20200821 compiled on ubuntu
I noticed this because mwan3 does some version checks on the ping version to assess its capabilities, and it was not detecting the version correctly.
The text was updated successfully, but these errors were encountered: