Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxc-create: requires getopts as a dep #16684

Closed
graysky2 opened this issue Sep 22, 2021 · 3 comments · Fixed by #17817
Closed

lxc-create: requires getopts as a dep #16684

graysky2 opened this issue Sep 22, 2021 · 3 comments · Fixed by #17817

Comments

@graysky2
Copy link
Contributor

Maintainer: @neheb
It seems that lxc-create requires getopt as a dependency but it is not pulled down when the package is installed.

# lxc-create --name myLMS --template download
/usr/share/lxc/templates/lxc-download: line 241: getopt: not found
LXC container image downloader
...
lxc-create: myLMS: lxccontainer.c: create_run_template: 1616 Failed to create container from template
lxc-create: myLMS: tools/lxc_create.c: main: 319 Failed to create container myLMS
@neheb
Copy link
Contributor

neheb commented Sep 22, 2021

I don't actually use or maintain LXC. Want to be a maintainer?

@graysky2
Copy link
Contributor Author

graysky2 commented Sep 22, 2021 •
edited
Loading

@neheb - My bad. I saw you several times in the history of Makefile plus your activity with it so assumed you were. I see Marko hard-coded in the Makefile ... how can I find Marko's github nick? Guess it is @robimarko

About maintaining it, I do not know the proper syntax for this project's Makefiles so probably not a good idea.

graysky2 added a commit to graysky2/packages that referenced this issue Feb 6, 2022
@graysky2
lxc-create: update depends to include getopt
d0aa9e8 
Fixes openwrt#16684

Build system: x86_64
Build-tested: bcm2711/RPi4B
Run-tested: bcm2711/RPi4B

Signed-off-by: John Audia <graysky@archlinux.us>
graysky2 added a commit to graysky2/packages that referenced this issue Feb 6, 2022
@graysky2
lxc-create: update depends to include getopt
66bdbb7 
Fixes openwrt#16684

Build system: x86_64
Build-tested: bcm2711/RPi4B
Run-tested: bcm2711/RPi4B

Signed-off-by: John Audia <graysky@archlinux.us>
graysky2 added a commit to graysky2/packages that referenced this issue Feb 6, 2022
@graysky2
lxc-create: update depends to include getopt
ddedb97 
Fixes openwrt#16684

Build system: x86_64
Build-tested: bcm2711/RPi4B
Run-tested: bcm2711/RPi4B

Signed-off-by: John Audia <graysky@archlinux.us>
@graysky2 graysky2 mentioned this issue Feb 6, 2022
Merged
BKPepe pushed a commit that referenced this issue Feb 7, 2022
@graysky2 @BKPepe
lxc-create: update depends to include getopt
e80835b 
Fixes #16684

Build system: x86_64
Build-tested: bcm2711/RPi4B
Run-tested: bcm2711/RPi4B

Signed-off-by: John Audia <graysky@archlinux.us>
Beginner-Go pushed a commit to coolsnowwolf/packages that referenced this issue Feb 9, 2022
@graysky2 @Beginner-Go
lxc-create: update depends to include getopt
240374e 
Fixes openwrt/packages#16684

Build system: x86_64
Build-tested: bcm2711/RPi4B
Run-tested: bcm2711/RPi4B

Signed-off-by: John Audia <graysky@archlinux.us>
1715173329 pushed a commit to immortalwrt/packages that referenced this issue Feb 18, 2022
@graysky2 @1715173329
lxc-create: update depends to include getopt
dab2add 
Fixes openwrt/packages#16684

Build system: x86_64
Build-tested: bcm2711/RPi4B
Run-tested: bcm2711/RPi4B

Signed-off-by: John Audia <graysky@archlinux.us>
Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
utoni pushed a commit to utoni/openwrt-packages that referenced this issue May 30, 2022
@graysky2 @utoni
lxc-create: update depends to include getopt
3380b64 
Fixes openwrt#16684

Build system: x86_64
Build-tested: bcm2711/RPi4B
Run-tested: bcm2711/RPi4B

Signed-off-by: John Audia <graysky@archlinux.us>
@rmilecki
Copy link
Contributor

I noticed this change while updating LXC in stable releases.

This change adds getopt as dependency of lxc-create. I see few problems here:

  1. lxc-create requires more than just getopt to work
  2. We already have LXC_BUSYBOX_OPTIONS which takes care of requirements (including getopt)
  3. We ended up with
    • lxc-create selecting getopt
    • LXC_BUSYBOX_OPTIONS selecting BUSYBOX_CONFIG_GETOPT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lxc-create: update depends to include getopt graysky2/packages
3 participants
@rmilecki @graysky2 @neheb