Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync the main branch today (2023-12-06), make menueconfig error: recursive dependency detected! #22837

Closed
1 task done
andersling opened this issue Dec 6, 2023 · 8 comments
Closed
1 task done

Sync the main branch today (2023-12-06), make menueconfig error: recursive dependency detected! #22837

andersling opened this issue Dec 6, 2023 · 8 comments
Labels
bug invalid

Comments

@andersling
Copy link

Describe the bug

openwrt_2312$ make menuconfig
tmp/.config-package.in:138254:error: recursive dependency detected!
tmp/.config-package.in:138254: symbol PACKAGE_prometheus-node-exporter-ucode depends on PACKAGE_ucode
tmp/.config-package.in:38903: symbol PACKAGE_ucode is selected by PACKAGE_uspotfilter
tmp/.config-package.in:124625: symbol PACKAGE_uspotfilter is selected by PACKAGE_uspot
tmp/.config-package.in:94297: symbol PACKAGE_uspot depends on PACKAGE_uhttpd
tmp/.config-package.in:116814: symbol PACKAGE_uhttpd is selected by PACKAGE_prometheus-node-exporter-ucode
For a resolution refer to Documentation/kbuild/kconfig-language.rst
subsection "Kconfig recursive dependency limitations"

please fix it ,guys, thanks!

OpenWrt version

r23966-6bf8193b25

OpenWrt release

20231206 latest

OpenWrt target/subtarget

master

Device

Raspberry Pi Compute Module 4 Rev 1.0

Image kind

Self-built image

Steps to reproduce

just do a sync feed, and make menuconfig ,and the message will show:

openwrt_2312$ make menuconfig
tmp/.config-package.in:138254:error: recursive dependency detected!
tmp/.config-package.in:138254: symbol PACKAGE_prometheus-node-exporter-ucode depends on PACKAGE_ucode
tmp/.config-package.in:38903: symbol PACKAGE_ucode is selected by PACKAGE_uspotfilter
tmp/.config-package.in:124625: symbol PACKAGE_uspotfilter is selected by PACKAGE_uspot
tmp/.config-package.in:94297: symbol PACKAGE_uspot depends on PACKAGE_uhttpd
tmp/.config-package.in:116814: symbol PACKAGE_uhttpd is selected by PACKAGE_prometheus-node-exporter-ucode
For a resolution refer to Documentation/kbuild/kconfig-language.rst
subsection "Kconfig recursive dependency limitations"

Actual behaviour

No response

Expected behaviour

No response

Additional info

No response

Diffconfig

No response

Terms

  • I am reporting an issue for OpenWrt, not an unsupported fork.
@andersling andersling added the bug label Dec 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Invalid Release reported. 20231206 latest
Is this from a clean repository?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Invalid Target/Subtarget reported. master
Is this from a supported device?

@andersling
Copy link
Author

Invalid Release reported. 20231206 latest Is this from a clean repository?

yes,sir bot!

@bauw2008
Copy link

bauw2008 commented Dec 7, 2023

The problem is: uspot: add package #22785

@ynezz ynezz transferred this issue from openwrt/openwrt Dec 7, 2023
@f00b4r0
Copy link
Contributor

f00b4r0 commented Dec 7, 2023

packages/utils/prometheus-node-exporter-ucode/Makefile

Line 56 in 3351219

DEPENDS:=$(PKG_NAME) $(3)

try changing DEPENDS:=$(PKG_NAME) $(3) to DEPENDS:=+$(PKG_NAME) $(3)

@f00b4r0
Copy link
Contributor

f00b4r0 commented Dec 7, 2023

@dhewg

packages/utils/prometheus-node-exporter-ucode/Makefile

Line 56 in 3351219

DEPENDS:=$(PKG_NAME) $(3)

try changing DEPENDS:=$(PKG_NAME) $(3) to DEPENDS:=+$(PKG_NAME) $(3)

@dhewg
Copy link
Contributor

dhewg commented Dec 7, 2023

No, that's not wanted. The additional collectors should only be select-able if the main package is selected. And that also prevents useless .config spam.

The issue seems related to ucode-mod-* as those have ucode as hard dependency. I have selects on some of those mods, but no direct ucode dependency nor select, but you do. Removing the two +ucode entries from uspot seems to solve this. Those shouldn't be needed anyway, as any ucode-mod-* drags it in already.

@f00b4r0
Copy link
Contributor

f00b4r0 commented Dec 7, 2023

@jow- what do you think?

openwrt-bot pushed a commit to openwrt/openwrt that referenced this issue Dec 7, 2023
@jow-
ucode: adjust module dependencies
982bfd9 
Let ucode-mod-* packages select the ucode interpreter instead of depending
on it to avoid recursive dependency chains in unrelated packages.

Fixes: openwrt/packages#22837
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 01d1c1a)
darknblack pushed a commit to darknblack/openwrt that referenced this issue Dec 9, 2023
@jow- @darknblack
ucode: adjust module dependencies
7550db0 
Let ucode-mod-* packages select the ucode interpreter instead of depending
on it to avoid recursive dependency chains in unrelated packages.

Fixes: openwrt/packages#22837
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this issue Dec 24, 2023
@jow- @Vladdrako
ucode: adjust module dependencies
8dae996 
Let ucode-mod-* packages select the ucode interpreter instead of depending
on it to avoid recursive dependency chains in unrelated packages.

Fixes: openwrt/packages#22837
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
db260179 pushed a commit to db260179/openwrt that referenced this issue Dec 24, 2023
@jow- @db260179
ucode: adjust module dependencies
5edd095 
Let ucode-mod-* packages select the ucode interpreter instead of depending
on it to avoid recursive dependency chains in unrelated packages.

Fixes: openwrt/packages#22837
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
JohnSanpe pushed a commit to JohnSanpe/openwrt that referenced this issue Jan 13, 2024
@jow- @JohnSanpe
ucode: adjust module dependencies
acb7a77 
Let ucode-mod-* packages select the ucode interpreter instead of depending
on it to avoid recursive dependency chains in unrelated packages.

Fixes: openwrt/packages#22837
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 01d1c1a)
sbeach92 pushed a commit to sbeach92/openwrt that referenced this issue Feb 16, 2024
@jow- @sbeach92
ucode: adjust module dependencies
e8bb4b8 
Let ucode-mod-* packages select the ucode interpreter instead of depending
on it to avoid recursive dependency chains in unrelated packages.

Fixes: openwrt/packages#22837
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
rondoval pushed a commit to rondoval/openwrt that referenced this issue Feb 25, 2024
@jow- @rondoval
ucode: adjust module dependencies
a62ec41 
Let ucode-mod-* packages select the ucode interpreter instead of depending
on it to avoid recursive dependency chains in unrelated packages.

Fixes: openwrt/packages#22837
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 01d1c1a)
Zack0617 pushed a commit to Zack0617/openwrt that referenced this issue Mar 25, 2024
@jow- @Zack0617
ucode: adjust module dependencies
d2705c2 
Let ucode-mod-* packages select the ucode interpreter instead of depending
on it to avoid recursive dependency chains in unrelated packages.

Fixes: openwrt/packages#22837
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 01d1c1ad296cc71f87ea02b01b16a09fe5d933a1)
Zack0617 pushed a commit to Zack0617/openwrt that referenced this issue Mar 25, 2024
@jow- @Zack0617
ucode: adjust module dependencies
8570852 
Let ucode-mod-* packages select the ucode interpreter instead of depending
on it to avoid recursive dependency chains in unrelated packages.

Fixes: openwrt/packages#22837
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 01d1c1ad296cc71f87ea02b01b16a09fe5d933a1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dhewg @andersling @f00b4r0 @bauw2008