Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgd: avoid using host headers #10079

Merged
merged 1 commit into from
Sep 26, 2019
Merged

libgd: avoid using host headers #10079

merged 1 commit into from
Sep 26, 2019

Conversation

ryzhovau
Copy link
Contributor

Maintainer: @jow-, @neheb
Compile tested: Clean Debian 10 stable host, Entware repo, mipsel feed (commit).
Run tested: Entware repo

Description: This PR removes host paths from CFLAGS, regression introduced after switch to CMake. Otherwise, libgd fails diring CMake tests:

make[5]: Entering directory '/home/Entware/build_dir/target-mipsel_mips 32r2_glibc-2.27/libgd-2.2.5/CMakeFiles/CMakeTmp'
Building C object CMakeFiles/cmTC_0b835.dir/HAVE_STDINT_H.c.o
/home/Entware/staging_dir/toolchain-mipsel_mips32r2_gcc-7.4.0_glibc-2.2 7/bin/mipsel-openwrt-linux-gnu-gcc  -I/usr/include -I/usr/local/include  -O2 -pi pe -mno-branch-likely -mips32r2 -mtune=mips32r2 -fno-caller-saves -fhonour-copts  -Wno-error=unused-but-set-variable -Wno-error=unused-result -msoft-float  -fpic  -ffunction-sections -fdata-sections -flto    -o CMakeFiles/cmTC_0b835.dir/HAVE_ STDINT_H.c.o   -c /home/Entware/build_dir/target-mipsel_mips32r2_glibc- 2.27/libgd-2.2.5/CMakeFiles/CheckIncludeFiles/HAVE_STDINT_H.c
In file included from /home/Entware/build_dir/target-mipsel_mips32r2_gl ibc-2.27/libgd-2.2.5/CMakeFiles/CheckIncludeFiles/HAVE_STDINT_H.c:2:0:
/usr/include/stdint.h:43:9: error: unknown type name '__int_least8_t'
 typedef __int_least8_t int_least8_t;
         ^~~~~~~~~~~~~~
/usr/include/stdint.h:44:9: error: unknown type name '__int_least16_t'
 typedef __int_least16_t int_least16_t;
         ^~~~~~~~~~~~~~~
/usr/include/stdint.h:45:9: error: unknown type name '__int_least32_t'
 typedef __int_least32_t int_least32_t;
         ^~~~~~~~~~~~~~~
/usr/include/stdint.h:46:9: error: unknown type name '__int_least64_t'
 typedef __int_least64_t int_least64_t;

@neheb
Copy link
Contributor

neheb commented Sep 26, 2019

Signed-off-by is missing or doesn't match author (should be 'Signed-off-by: Alexander Ryzhov github@ryzhov-al.ru')

@ryzhovau ryzhovau force-pushed the libgd_CFLAGS branch 2 times, most recently from e186b91 to 29b6b07 Compare September 26, 2019 10:40
Signed-off-by: Alexander Ryzhov <github@ryzhov-al.ru>
@karlp
Copy link
Contributor

karlp commented Sep 26, 2019

yet MORE regressions from gratuitously changing build systems!

@neheb neheb merged commit 8ed2d22 into openwrt:master Sep 26, 2019
@ryzhovau ryzhovau deleted the libgd_CFLAGS branch September 27, 2019 06:08
willson-chen pushed a commit to libgd/libgd that referenced this pull request Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants