-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openblas: initial package draft #11894
Conversation
@brada4 I don't know how we could be handle |
libs/openblas/Makefile
Outdated
#PKG_SOURCE_URL:=https://github.com/xianyi/OpenBLAS/archive/ | ||
PKG_SOURCE_PROTO:=git | ||
PKG_SOURCE_DATE:=2020-04-19 | ||
PKG_SOURCE_URL:=https://github.com/martin-frbg/OpenBLAS.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a good idea to point to release tarballs, unless impossible;
from what i can tell, that should be doable for this repo;
but i am a bit confused about the official tarball for this package;
you are pointing to https://github.com/martin-frbg/OpenBLAS.git
officially it's another repo;
if you need patches from that repo, pick them out and put them in the patches
sub-folder of the package;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cause I was working on a specific PR to test in docker run --rm -it openwrtorg/sdk:ramips-mt76x8-19.07.2
.
See OpenMathLib/OpenBLAS#2565
libs/openblas/Makefile
Outdated
# Package build instructions; invoke the GNU make tool to build our package | ||
define Build/Compile | ||
$(MAKE) -C $(PKG_BUILD_DIR) \ | ||
TARGET='MIPS24K' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you intend to support openblas only for MIPS24K?
if so, maybe you should limit the depends a bit;
example how to do it per-arch: DEPENDS:=@(i386||x86_64||arm||armeb||aarch64||powerpc||mips||mipsel)
you can probably just put mips
though it may make sense to try to target all archs if possible [somehow]
otherwise, a package [like this] may not make sense for just 1 arch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to build for all the archs.
24K Is the one that I am interesting to compile on with docker run --rm -it openwrtorg/sdk:ramips-mt76x8-19.07.2
.
The issue Is that Openblas for cross-compiling requires TARGET
as you can see from https://github.com/xianyi/OpenBLAS/blob/develop/README.md#cross-compile.
And for TARGET
we need to use a value from this list
hmm; so openblas makes sense maybe after numpy is added; |
Yes see https://numpy.org/doc/1.18/user/building.html#accelerated-blas-lapack-libraries |
Move back on the official git repo
@commodo |
Also I don't know how we could dynamically handle the required |
we can alias mipsel to openblas mips if that helps to streamline the process here??? |
let's get ready with this: we can take a look at this afterwards; |
Initial draft PR is: openwrt#11894 This one is a bit more complete and tested, and follows packaging practices. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete and tested, and follows packaging practices. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete and tested, and follows packaging practices. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete, and follows packaging practices. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete, and follows packaging practices. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete, and follows packaging practices. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
this will be superseded by #15685 |
Thanks |
Initial draft PR is: openwrt#11894 This one is a bit more complete, and follows packaging practices. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete, and follows packaging practices. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt/packages#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com> Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
Initial draft PR is: openwrt/packages#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt/packages#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt/packages#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt/packages#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt/packages#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Initial draft PR is: openwrt/packages#11894 This one is a bit more complete, and follows packaging practices. For now, disabling builds on ARC and PowerPC. Will require more work to get them going. Explicitly disabling OpenMP support, so that it doesn't get picked by accident. Later we may use the `CPU_TYPE` parameter to tweak things a little further. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Maintainer: me
Compile tested: (mips 24kec, 19.07.2)
Run tested: (none)
Description:
Iinitial stub for Openblas. It could be also useful to accelerate Numpy package if recovered at #9797 (comment)
/cc @brada4