Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openblas: initial package draft #11894

Closed
wants to merge 2 commits into from
Closed

Openblas: initial package draft #11894

wants to merge 2 commits into from

Conversation

bhack
Copy link

@bhack bhack commented Apr 19, 2020

Maintainer: me
Compile tested: (mips 24kec, 19.07.2)
Run tested: (none)

Description:
Iinitial stub for Openblas. It could be also useful to accelerate Numpy package if recovered at #9797 (comment)

/cc @brada4

@bhack bhack mentioned this pull request Apr 19, 2020
@bhack
Copy link
Author

bhack commented Apr 19, 2020

@brada4 I don't know how we could be handle TARGET= that is requested to cross-compile Openblas in openwrt.

#PKG_SOURCE_URL:=https://github.com/xianyi/OpenBLAS/archive/
PKG_SOURCE_PROTO:=git
PKG_SOURCE_DATE:=2020-04-19
PKG_SOURCE_URL:=https://github.com/martin-frbg/OpenBLAS.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a good idea to point to release tarballs, unless impossible;
from what i can tell, that should be doable for this repo;
but i am a bit confused about the official tarball for this package;
you are pointing to https://github.com/martin-frbg/OpenBLAS.git officially it's another repo;

if you need patches from that repo, pick them out and put them in the patches sub-folder of the package;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cause I was working on a specific PR to test in docker run --rm -it openwrtorg/sdk:ramips-mt76x8-19.07.2.
See OpenMathLib/OpenBLAS#2565

# Package build instructions; invoke the GNU make tool to build our package
define Build/Compile
$(MAKE) -C $(PKG_BUILD_DIR) \
TARGET='MIPS24K' \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you intend to support openblas only for MIPS24K?
if so, maybe you should limit the depends a bit;
example how to do it per-arch: DEPENDS:=@(i386||x86_64||arm||armeb||aarch64||powerpc||mips||mipsel)
you can probably just put mips

though it may make sense to try to target all archs if possible [somehow]
otherwise, a package [like this] may not make sense for just 1 arch

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to build for all the archs.
24K Is the one that I am interesting to compile on with docker run --rm -it openwrtorg/sdk:ramips-mt76x8-19.07.2.
The issue Is that Openblas for cross-compiling requires TARGET as you can see from https://github.com/xianyi/OpenBLAS/blob/develop/README.md#cross-compile.
And for TARGET we need to use a value from this list

@commodo
Copy link
Contributor

commodo commented Apr 21, 2020

hmm; so openblas makes sense maybe after numpy is added;
until then we can review it;

libs/openblas/Makefile Outdated Show resolved Hide resolved
@bhack
Copy link
Author

bhack commented Apr 21, 2020

hmm; so openblas makes sense maybe after numpy is added;
until then we can review it;

Yes see https://numpy.org/doc/1.18/user/building.html#accelerated-blas-lapack-libraries

Move back on the official git repo
@bhack
Copy link
Author

bhack commented Apr 21, 2020

@commodo ARCH is landing mipsel but openblas wants mips. I think is correct mips as I see in https://www.mips.com/develop/linux/.
Why we have that set to mipsel?

@bhack
Copy link
Author

bhack commented Apr 21, 2020

Also I don't know how we could dynamically handle the required TARGET to set in MAKE_VARS.
See OpenMathLib/OpenBLAS#2570

@brada4
Copy link

brada4 commented Apr 21, 2020

we can alias mipsel to openblas mips if that helps to streamline the process here???

@commodo
Copy link
Contributor

commodo commented Jun 4, 2020

let's get ready with this:
#12404

we can take a look at this afterwards;

commodo added a commit to commodo/packages that referenced this pull request Feb 26, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete and tested, and follows packaging
practices.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request Feb 26, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete and tested, and follows packaging
practices.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request Apr 28, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete and tested, and follows packaging
practices.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request May 24, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete, and follows packaging practices.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request May 24, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete, and follows packaging practices.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request May 24, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete, and follows packaging practices.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
@commodo
Copy link
Contributor

commodo commented May 24, 2021

this will be superseded by #15685

@bhack
Copy link
Author

bhack commented May 24, 2021

Thanks

@bhack bhack closed this May 24, 2021
commodo added a commit to commodo/packages that referenced this pull request May 25, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete, and follows packaging practices.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request May 25, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete, and follows packaging practices.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request May 25, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request May 28, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request Jun 2, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request Jun 2, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request Jun 2, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request Jun 16, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request Jul 5, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request Jul 6, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
commodo added a commit to commodo/packages that referenced this pull request Jul 26, 2021
Initial draft PR is:
  openwrt#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
1715173329 pushed a commit to immortalwrt/packages that referenced this pull request Jul 27, 2021
Initial draft PR is:
  openwrt/packages#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
Lienol pushed a commit to Lienol/openwrt-packages that referenced this pull request Dec 8, 2021
Initial draft PR is:
  openwrt/packages#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Lienol pushed a commit to Lienol/openwrt-packages that referenced this pull request Dec 9, 2021
Initial draft PR is:
  openwrt/packages#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Lienol pushed a commit to Lienol/openwrt-packages that referenced this pull request Dec 19, 2021
Initial draft PR is:
  openwrt/packages#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
utoni pushed a commit to utoni/openwrt-packages that referenced this pull request Jan 21, 2022
Initial draft PR is:
  openwrt#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Lienol pushed a commit to Lienol/openwrt-packages that referenced this pull request Feb 2, 2022
Initial draft PR is:
  openwrt/packages#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Lienol pushed a commit to Lienol/openwrt-packages that referenced this pull request Feb 11, 2022
Initial draft PR is:
  openwrt/packages#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
ArmyOfPirates pushed a commit to ArmyOfPirates/packages that referenced this pull request Feb 12, 2022
Initial draft PR is:
  openwrt#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
1582130940 pushed a commit to 1582130940/OpenWrt-Lean-Packages that referenced this pull request Nov 8, 2022
Initial draft PR is:
  openwrt/packages#11894

This one is a bit more complete, and follows packaging practices.

For now, disabling builds on ARC and PowerPC. Will require more work to get
them going.
Explicitly disabling OpenMP support, so that it doesn't get picked by
accident.

Later we may use the `CPU_TYPE` parameter to tweak things a little further.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants