Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim: Do not make autowrite default #12177

Closed
wants to merge 1 commit into from

Conversation

dermoth
Copy link
Contributor

@dermoth dermoth commented May 15, 2020

Making autowrite the default is dangerous. Moving around multiple files
or sending vim to the background will make vim silently write all open
files. While this can be a great developer feature it's likely a very bad
idea for a sysadmin editing critical config files.

Maintainer: Marko Ratkaj marko.ratkaj@sartura.hr
Compile tested: N/A - Config file
Run tested: VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Jul 21 2018 08:08:45)

@dermoth dermoth changed the title Do not make autowrite default vim: Do not make autowrite default May 15, 2020
Making autowrite the default is dangerous. Moving around multiple files
or sending vim to the background will make vim silently write all open
files. While this can be a great developer feature it's likely a very bad
idea for a sysadmin editing critical config files.

Signed-off-by: Thomas Guyot-Sionnest <dermoth@aei.ca>
@neheb
Copy link
Contributor

neheb commented May 16, 2020

Needs a PKG_RELEASE bump.

@hnyman
Copy link
Contributor

hnyman commented Jun 6, 2020

cc @ratkaj

neheb added a commit to neheb/packages that referenced this pull request Jul 28, 2020
Removed multibyte options. They must now be enabled.

Refreshed patches.

Commented out autowrite as requested in
openwrt#12177

Signed-off-by: Rosen Penev <rosenp@gmail.com>
neheb added a commit to neheb/packages that referenced this pull request Jul 28, 2020
Removed multibyte options. They must now be enabled.

Refreshed patches.

Commented out autowrite as requested in
openwrt#12177

Signed-off-by: Rosen Penev <rosenp@gmail.com>
neheb added a commit to neheb/packages that referenced this pull request Jul 28, 2020
Removed multibyte options. They must now be enabled.

Refreshed patches.

Commented out autowrite as requested in
openwrt#12177

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb neheb mentioned this pull request Jul 28, 2020
@neheb
Copy link
Contributor

neheb commented Jul 30, 2020

Merged this

@neheb neheb closed this Jul 30, 2020
1715173329 pushed a commit to immortalwrt/packages that referenced this pull request Jul 30, 2020
Removed multibyte options. They must now be enabled.

Refreshed patches.

Commented out autowrite as requested in
openwrt/packages#12177

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@nobk
Copy link

nobk commented Jul 30, 2020

target x86_64, vim-fuller option, got iconv error:
msgfmt: Cannot convert from "ISO-8859-1" to "UTF-8". msgfmt relies on iconv(). This version was built without iconv()

@nobk
Copy link

nobk commented Aug 3, 2020

OLD_PO_FILE_INPUT=yes msgfmt -v -o uk.cp1251.mo uk.cp1251.po
1963 translated messages.
OLD_PO_FILE_INPUT=yes msgfmt -v -o zh_CN.cp936.mo zh_CN.cp936.po
1623 translated messages, 3 fuzzy translations.
echo af ca cs cs.cp1250 da de en_GB eo es fi fr ga it ja ja.euc-jp ja.sjis ko ko.UTF-8 lv nb nl no pl pl.UTF-8 pl.cp1250 pt_BR ru ru.cp1251 sk sk.cp1250 sr sv tr uk uk.cp1251 vi zh_CN zh_CN.UTF-8 zh_CN.cp936 zh_TW zh_TW.UTF-8  | tr " " "\n" |sed -e '/\./d' | sort > LINGUAS
msgfmt --desktop -d . --template gvim.desktop.in -o tmp_gvim.desktop
msgfmt: Cannot convert from "ISO-8859-1" to "UTF-8". msgfmt relies on iconv(). This version was built without iconv().
make[5]: *** [Makefile:177: gvim.desktop] Error 1
make[5]: Leaving directory '/build/build_dir/target-x86_64_musl/vim82/src/po'
make[4]: *** [Makefile:2092: languages] Error 2
make[4]: Leaving directory '/build/build_dir/target-x86_64_musl/vim82/src'
make[3]: *** [Makefile:39: all] Error 2
make[3]: Leaving directory '/build/build_dir/target-x86_64_musl/vim82'
make[2]: *** [Makefile:257: /build/build_dir/target-x86_64_musl/vim82/.built] Error 2
make[2]: Leaving directory '/build/feeds/packages/utils/vim'
time: package/feeds/packages/vim/compile#71.77#5.86#74.58
make[1]: *** [package/Makefile:113: package/feeds/packages/vim/compile] Error 2
make[1]: Leaving directory '/build'
make: *** [/build/include/toplevel.mk:235: package/vim/compile] Error 2

@neheb
Copy link
Contributor

neheb commented Aug 5, 2020

That error is due to gettext-full/host . Not relevant here.

Is this on macos?

@EdiTurn
Copy link
Contributor

EdiTurn commented Aug 5, 2020

@neheb I also got this error only recent days .
target x86_64, build on Arch Linux.
Simply delete msgfmt may solve the problem temporarily, but ...

#build image untiil error occured
rm staging_dir/hostpkg/bin/msgfmt
#contiune to make

farmergreg pushed a commit to farmergreg/packages that referenced this pull request Sep 8, 2020
Removed multibyte options. They must now be enabled.

Refreshed patches.

Commented out autowrite as requested in
openwrt#12177

Signed-off-by: Rosen Penev <rosenp@gmail.com>
farmergreg pushed a commit to farmergreg/packages that referenced this pull request Sep 8, 2020
Removed multibyte options. They must now be enabled.

Refreshed patches.

Commented out autowrite as requested in
openwrt#12177

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants