-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vim: Do not make autowrite default #12177
Conversation
Making autowrite the default is dangerous. Moving around multiple files or sending vim to the background will make vim silently write all open files. While this can be a great developer feature it's likely a very bad idea for a sysadmin editing critical config files. Signed-off-by: Thomas Guyot-Sionnest <dermoth@aei.ca>
Needs a PKG_RELEASE bump. |
cc @ratkaj |
Removed multibyte options. They must now be enabled. Refreshed patches. Commented out autowrite as requested in openwrt#12177 Signed-off-by: Rosen Penev <rosenp@gmail.com>
Removed multibyte options. They must now be enabled. Refreshed patches. Commented out autowrite as requested in openwrt#12177 Signed-off-by: Rosen Penev <rosenp@gmail.com>
Removed multibyte options. They must now be enabled. Refreshed patches. Commented out autowrite as requested in openwrt#12177 Signed-off-by: Rosen Penev <rosenp@gmail.com>
Merged this |
Removed multibyte options. They must now be enabled. Refreshed patches. Commented out autowrite as requested in openwrt/packages#12177 Signed-off-by: Rosen Penev <rosenp@gmail.com>
target x86_64, vim-fuller option, got iconv error: |
|
That error is due to gettext-full/host . Not relevant here. Is this on macos? |
@neheb I also got this error only recent days .
|
Removed multibyte options. They must now be enabled. Refreshed patches. Commented out autowrite as requested in openwrt#12177 Signed-off-by: Rosen Penev <rosenp@gmail.com>
Removed multibyte options. They must now be enabled. Refreshed patches. Commented out autowrite as requested in openwrt#12177 Signed-off-by: Rosen Penev <rosenp@gmail.com>
Making autowrite the default is dangerous. Moving around multiple files
or sending vim to the background will make vim silently write all open
files. While this can be a great developer feature it's likely a very bad
idea for a sysadmin editing critical config files.
Maintainer: Marko Ratkaj marko.ratkaj@sartura.hr
Compile tested: N/A - Config file
Run tested: VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Jul 21 2018 08:08:45)