Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-lfs: add new package #13929

Merged
merged 1 commit into from
Feb 21, 2021
Merged

git-lfs: add new package #13929

merged 1 commit into from
Feb 21, 2021

Conversation

ja-pa
Copy link
Contributor

@ja-pa ja-pa commented Nov 16, 2020

Maintainer: me
Compile tested: Turris Omnia (TOS6), OpenWrt master
Run tested: Turris Omnia (TOS6), OpenWrt master

Description:
This PR adds new package git-lfs. It helps to store large file inside git.

This is related to PR #13919. It is one of the required packages from GitLab to run custom executor https://docs.gitlab.com/runner/executors/custom.html#prerequisite-software-for-running-a-job

@ja-pa
Copy link
Contributor Author

ja-pa commented Dec 9, 2020

There is error for x86_64, i386, arm, aarch64

No packages removed.
 * pkg_run_script: Internal error: perlbase-i18n has a NULL tmp_unpack_dir.
 * pkg_run_script: Internal error: perlbase-i18n has a NULL tmp_unpack_dir.
Error: Process completed with exit code 255.

I'm not sure if this is related to git-lfs

@ja-pa ja-pa marked this pull request as ready for review December 9, 2020 13:02
@BKPepe
Copy link
Member

BKPepe commented Dec 9, 2020

@jefferyto may I ask you if you can take a look? :)

@jefferyto
Copy link
Member

Perhaps unsurprisingly, there are -X ldflags that can be set with GO_PKG_LDFLAGS_X. Otherwise the package looks fine to me.

@aparcar would be the better person to ask regarding the CI errors.

@BKPepe
Copy link
Member

BKPepe commented Jan 24, 2021

@ja-pa Can you please rebase it and take a look at Jeffery's feedback, please?

@ja-pa ja-pa force-pushed the git-lfs branch 2 times, most recently from debc5ff to 141f016 Compare February 11, 2021 13:05
Signed-off-by: Jan Pavlinec <jan.pavlinec@nic.cz>
@BKPepe BKPepe merged commit 8dc0d3d into openwrt:master Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants