-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] etebase: add package #14063
[RFC] etebase: add package #14063
Conversation
Please rebase to remove the red checkmarks. |
51644a3
to
ae35109
Compare
Rebased, thank you :-) |
ping @jefferyto |
Is it necessary to have both etesync-server and etebase available to be able to migrate users? How hard would it be to clear all etesync-server data and recreate it for etebase (by the user manually)? (Apologies if these are silly questions, I'm not familiar with this software.) Since etesync-server isn't available on any release branch, my preference would be to have a clean break and rename etesync-server to etebase directly. Otherwise we have no clear criteria for how long to keep etesync-server around. Also, I would prefer this renaming/duplicating the package to be done in a few commits rather than one; the diff is hard to read when it combines renames and other functional changes. I suggest one commit where |
Signed-off-by: Peter Stadler <peter.stadler@student.uibk.ac.at>
Signed-off-by: Peter Stadler <peter.stadler@student.uibk.ac.at>
ae35109
to
6d20bbf
Compare
Thank you, this are very good hints :-) To answer your questions, I would distinguish:
The official guide wants it so: The hoster needs to create new accounts for each end user (here the etesync database can be used as source for user names). Then the end users can migrate their data on their own. I tested both migration tools:
I suppose for the typical use case on OpenWrt it would work to migrate without etesync-server.
The hoster can delete one database for clearing the data, but there is no way for recreating the data (as it is encrypted and there changed too much). The end users can use one of the copies in their clients (I suppose this is what the migration tool does internally). So, I made two commits renaming the package |
I take it this is ready? |
@peter-stadler thanks for the updates 😄
I don't think either is strictly necessary; it's fine to have more than one commit in one PR.
This is a nice (if perhaps unintentional) side effect to allow both etesync-server and etebase to be installed at the same time. I take it though that the web migration tool needs both running at the same time but this would not be possible with the current (default) config? I don't think this is a great loss (if someone is using master they should expect to deal with things breaking). If running both is necessary for the migration and there are simple steps they can take to make this happen, it would be nice to document it either in a readme or just here in the PR. |
Thank you. So I think it is ready :-) Actually the default configs are ready to run etesync-server and etebase at the same time (they are available at https://192.168.1.1/etesync and https://192.168.1.1/etebase) and the web migration tool works (I used it to migrate one account). But the device needs enough RAM to run both servers simultaneously (each of them needs about 35 MB). The web migration tool first pulls all the data from etesync (not needing etebase running) and then pushes it to etebase (not needing etesync-server running anymore). So as a workaround with less than 70 MB free RAM you could:
Then there should be only one of the two servers running at a time. |
This package was originally added[1] as it was a dependency of etesync-server 0.3.0. When etesync-server was renamed to etebase and upgraded to 0.6.1[2], this dependency was removed. No other package in the packages feed depends on this package. Upstream has also archived the git repo[3] and stated that the repo/package is deprecated. It does not appear that any newer version of etebase uses this package. This removes the python3-django-etesync-journal package; it will be submitted to the abandoned packages repo. [1]: openwrt#10469 [2]: openwrt#14063 [3]: https://github.com/etesync/journal-manager Signed-off-by: Jeffery To <jeffery.to@gmail.com>
This package was originally added[1] as it was a dependency of etesync-server 0.3.0. When etesync-server was renamed to etebase and upgraded to 0.6.1[2], this dependency was removed. No other package in the packages feed depends on this package. Upstream has also archived the git repo[3] and stated that the repo/package is deprecated. It does not appear that any newer version of etebase uses this package. This removes the python3-django-etesync-journal package; it will be submitted to the abandoned packages repo. [1]: #10469 [2]: #14063 [3]: https://github.com/etesync/journal-manager Signed-off-by: Jeffery To <jeffery.to@gmail.com>
This package was originally added[1] as it was a dependency of etesync-server 0.3.0. When etesync-server was renamed to etebase and upgraded to 0.6.1[2], this dependency was removed. No other package in the packages feed depends on this package. Upstream has also archived the git repo[3] and stated that the repo/package is deprecated. It does not appear that any newer version of etebase uses this package. This removes the python3-django-etesync-journal package; it will be submitted to the abandoned packages repo. [1]: openwrt#10469 [2]: openwrt#14063 [3]: https://github.com/etesync/journal-manager Signed-off-by: Jeffery To <jeffery.to@gmail.com>
This package was originally added[1] as it was a dependency of etesync-server 0.3.0. When etesync-server was renamed to etebase and upgraded to 0.6.1[2], this dependency was removed. No other package in the packages feed depends on this package. Upstream has also archived the git repo[3] and stated that the repo/package is deprecated. It does not appear that any newer version of etebase uses this package. This removes the python3-django-etesync-journal package; it will be submitted to the abandoned packages repo. [1]: openwrt#10469 [2]: openwrt#14063 [3]: https://github.com/etesync/journal-manager Signed-off-by: Jeffery To <jeffery.to@gmail.com>
This package was originally added[1] as it was a dependency of etesync-server 0.3.0. When etesync-server was renamed to etebase and upgraded to 0.6.1[2], this dependency was removed. No other package in the packages feed depends on this package. Upstream has also archived the git repo[3] and stated that the repo/package is deprecated. It does not appear that any newer version of etebase uses this package. This removes the python3-django-etesync-journal package; it will be submitted to the abandoned packages repo. [1]: openwrt#10469 [2]: openwrt#14063 [3]: https://github.com/etesync/journal-manager Signed-off-by: Jeffery To <jeffery.to@gmail.com>
This package was originally added[1] as it was a dependency of etesync-server 0.3.0. When etesync-server was renamed to etebase and upgraded to 0.6.1[2], this dependency was removed. No other package in the packages feed depends on this package. Upstream has also archived the git repo[3] and stated that the repo/package is deprecated. It does not appear that any newer version of etebase uses this package. This removes the python3-django-etesync-journal package; it will be submitted to the abandoned packages repo. [1]: openwrt#10469 [2]: openwrt#14063 [3]: https://github.com/etesync/journal-manager Signed-off-by: Jeffery To <jeffery.to@gmail.com>
Maintainer: me
Compile tested: x86_64, x86_64 qemu, master
Run tested: x86_64, x86_64 qemu, master, run it
Description: This is the new version of
etesync-server
.Question: As it changed quite a bit needing a manual migration of the users and is also renamed to
etebase
, I would create a new package with the same name. Is this a good way, also in regard of deprecating theetesync-server
package later on (is this possible)?