Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ddns provider #14551

Merged
merged 3 commits into from Jan 26, 2021
Merged

Fix ddns provider #14551

merged 3 commits into from Jan 26, 2021

Conversation

geraldhansen
Copy link
Contributor

Maintainer: none
Compile tested: x86 openwrt-19.07.5
Run tested: VirtualBox

Description:

  • Change parameter for myonlineportal
    As the default uclient-fetch doesn't support authentication header
    and the ddns provider myonlineportal.net support also username and
    passwort as url parameter this can be changed.
  • Remove not working ddns provider
    I checked the hostname for existing DNS A and AAAA entries and these
    ones didn't have an entry.

@hnyman
Copy link
Contributor

hnyman commented Jan 24, 2021

This PR currently included in addition to your 2 commits also quite 15 unrelated commits.
You should likely rebase fix-ddns-provider branch on top on the master branch

@geraldhansen
Copy link
Contributor Author

Rebased to openwrt/packages:master

@neheb
Copy link
Contributor

neheb commented Jan 25, 2021

change PKG_RELEASE to $(AUTORELEASE) . See #14537

@geraldhansen
Copy link
Contributor Author

change PKG_RELEASE to $(AUTORELEASE) . See #14537

is this something I have to do?

@neheb
Copy link
Contributor

neheb commented Jan 25, 2021

Scratch that. Just bump the PKG_RELEASE variable. Autorelease is not appropriate here.

@geraldhansen
Copy link
Contributor Author

I removed the PKG_RELEASE variable from the Makefile

@feckert
Copy link
Member

feckert commented Jan 26, 2021

Sorry but @neheb meant to increase it by one, and not to remove the number.

- PKG_RELEASE:=5
+ PKG_RELEASE:=6

You could also change this to

- PKG_RELEASE:=5
+ PKG_RELEASE:=$(AUTORELEASE) 

Then the buildsystem takes care of it and we don't have to count up the number all the time.

However, I would prefer the first method first, which now has a smaller impact, because the second method is quit new.

@geraldhansen
Copy link
Contributor Author

Ok, I got it and changed it.

@feckert
Copy link
Member

feckert commented Jan 26, 2021

Sorry but the Pullrequest needs another rebase to current master

Gerald Hansen and others added 3 commits January 26, 2021 11:24
As the default uclient-fetch doesn't support authentication header
and the ddns provider myonlineportal.net support also username and
passwort as url parameter this can be changed.

Signed-off-by: Gerald Hansen <gerald.hansen@cloud.ionos.com>
I checked the hostname for existing DNS A and AAAA entries and these
ones didn't have an entry.

Signed-off-by: Gerald Hansen <gerald.hansen@cloud.ionos.com>
Signed-off-by: Gerald Hansen <gerald.hansen@posteo.de>
@geraldhansen
Copy link
Contributor Author

Rebase done

@feckert feckert merged commit d048c4b into openwrt:master Jan 26, 2021
@feckert
Copy link
Member

feckert commented Jan 26, 2021

I don't use these providers, so I can't say if the change works and if we can remove the others.
Opensource is based on trust, so thank you.
Merged.

@geraldhansen
Copy link
Contributor Author

Thanks, I tested them of course and also the one I removed.
If anyone complains, blame me and I will re-add them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants